Skip to content

Commit 73b4f77

Browse files
authored
open-metadata#23774 : fix the bulk import column name contains dot in it (open-metadata#23791)
* fix the bulk import column name contains dot in it * fix for name field * fix the failing test * fix the test failure
1 parent 8c02775 commit 73b4f77

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/BulkImport.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import {
3030
} from '../../utils/common';
3131
import {
3232
createColumnRowDetails,
33+
createColumnRowDetailsWithEncloseDot,
3334
createCustomPropertiesForEntity,
3435
createDatabaseRowDetails,
3536
createDatabaseSchemaRowDetails,
@@ -104,7 +105,7 @@ const columnDetails1 = {
104105
};
105106

106107
const columnDetails2 = {
107-
...createColumnRowDetails(),
108+
...createColumnRowDetailsWithEncloseDot(),
108109
glossary: glossaryDetails,
109110
};
110111

@@ -712,7 +713,7 @@ test.describe('Bulk Import Export', () => {
712713
await fillRecursiveColumnDetails(
713714
{
714715
...columnDetails2,
715-
fullyQualifiedName: `${dbSchemaEntity.entityResponseData.fullyQualifiedName}.${tableDetails2.name}.${columnDetails2.name}`,
716+
fullyQualifiedName: `${dbSchemaEntity.entityResponseData.fullyQualifiedName}.${tableDetails2.name}."${columnDetails2.name}"`,
716717
},
717718
page
718719
);
@@ -841,7 +842,6 @@ test.describe('Bulk Import Export', () => {
841842
}
842843
);
843844

844-
await tableEntity.delete(apiContext);
845845
await afterAction();
846846
});
847847

openmetadata-ui/src/main/resources/ui/playwright/utils/importUtils.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -505,6 +505,13 @@ export const createColumnRowDetails = () => {
505505
};
506506
};
507507

508+
export const createColumnRowDetailsWithEncloseDot = () => {
509+
return {
510+
...createColumnRowDetails(),
511+
name: `"playwright.column ${uuid()}"`,
512+
};
513+
};
514+
508515
export const createStoredProcedureRowDetails = () => {
509516
return {
510517
name: `playwright,storedprocedure,${uuid()}`,

openmetadata-ui/src/main/resources/ui/src/utils/CSV/CSVUtilsClassBase.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ class CSVUtilsClassBase {
5555
'column.tags',
5656
'column.glossaryTerms',
5757
'storedProcedure.code',
58+
'column.name*',
59+
'name*',
5860
];
5961
}
6062

0 commit comments

Comments
 (0)