Great job on your prev ticket!! everything works as expected. i verified the ses flow with my own keys, confirmed the automated dono response fires and sends me an email, i also checked that bulk sending works.
i'm creating a new ticket mainly for security (authguard commented out), but while u are at it, there is just a couple more things and this feature will be solidified!
- Re-enable the AuthGuard: we cant leave endpoints for bulk sending and template management public, or anyone could send spam or overwrite our settings.
- as a standard, we need to have plain-text alternatives and a proper unsubscribe link in the footer.
- make sure images are hosted on a cdn/s3 instead of being referenced locally. I will be doing that when i build the email signature.
- add some basic logs for bulk failures and wrap the variable replacements in try/catch.
Acceptance Criteria
- Emails don't go to spam
- images not referenced locally, it should be a link like https://...
- Authguard enabled
- logs
Additional notes:
- i just built the save/load logic on the frontend so changes don't disappear on refresh.
Great job on your prev ticket!! everything works as expected. i verified the ses flow with my own keys, confirmed the automated dono response fires and sends me an email, i also checked that bulk sending works.
i'm creating a new ticket mainly for security (authguard commented out), but while u are at it, there is just a couple more things and this feature will be solidified!
Acceptance Criteria
Additional notes: