Skip to content

Commit fdf53e0

Browse files
fix: filter out empty named symbols when building perf-map
1 parent dc07014 commit fdf53e0

5 files changed

Lines changed: 18 additions & 10 deletions

src/executor/wall_time/perf/perf_map.rs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,16 @@ impl ModuleSymbols {
100100
}
101101
}
102102

103-
// Filter out any symbols that still have zero size
104-
symbols.retain(|symbol| symbol.size > 0);
103+
// Filter out any symbols that still have zero size or an empty name
104+
symbols.retain(|symbol| {
105+
let should_keep = symbol.size > 0 && !symbol.name.is_empty();
106+
107+
if !should_keep {
108+
trace!("Filtering out symbol: {symbol:?}");
109+
}
110+
111+
should_keep
112+
});
105113

106114
if symbols.is_empty() {
107115
return Err(anyhow::anyhow!("No symbols found"));
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
version https://git-lfs.github.com/spec/v1
2-
oid sha256:cecbdde3c24b806a75f9e8a438f82419f33f9fcc86b9966352685a35784abec6
3-
size 520675
2+
oid sha256:3a775c5e200672234bbf71312cd4db90bfb81cf99907ca0b7c45cc38cb34679f
3+
size 520147
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
version https://git-lfs.github.com/spec/v1
2-
oid sha256:da29e6ceb514be0437b501e406016656d2ddbc9f1cd0619ea29df64e7bc69e54
3-
size 568064
2+
oid sha256:e72d1de3d0e4984f132ed2573cf996015da2db162df712bd58abe64fda510005
3+
size 567622
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
version https://git-lfs.github.com/spec/v1
2-
oid sha256:8355b90acf9569acb7288849bda81ec1d10b8457245088ed78835df7d6785fdc
3-
size 499264
2+
oid sha256:96076d39277b33ed3bbe060af13400acf3007a61c4b28fe5d93609122774a8dc
3+
size 498482
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
version https://git-lfs.github.com/spec/v1
2-
oid sha256:f74ef3ee84c89fc51e4546c0d8a41fe4565f91004eb80bed83812df31d01e4fb
3-
size 557917
2+
oid sha256:4fba1f2413398a08fb12a54ecbefbf69c3a18cf5bf9d544386f2e1d794bf81f1
3+
size 557134

0 commit comments

Comments
 (0)