build: bump eslint and @typescript-eslint to v8 line

The previous @typescript-eslint 5.58 and eslint 7.32 stack predated
TypeScript 5.x, and @typescript-eslint warned at startup that the
installed TS version was not officially supported. Bump eslint to
^8.57 and @typescript-eslint to ^8.57 — the latter officially supports
TS 5.x, which matches the recent TS bump.

The v8 rename surfaces a few rule-name changes that need to be applied
where the codebase used eslint-disable comments:

- @typescript-eslint/no-var-requires → no-require-imports
- @typescript-eslint/ban-types → no-unsafe-function-type for the
  Function-type uses in benchmark.js-plugin's add() overloads

Add a one-line disable for an intentionally-side-effecting expression
in benchmark.js-plugin/benches/sample.ts that the v8 recommended
config now flags as @typescript-eslint/no-unused-expressions.

Refs COD-2721
Co-Authored-By: Claude <noreply@anthropic.com>

Author: GuillaumeLagrange

package.json

@@ -20,13 +20,13 @@
     "@rollup/plugin-typescript": "^11.1.5",
     "@types/jest": "^29.5.0",
     "@types/node": "^20.5.1",
-    "@typescript-eslint/eslint-plugin": "^5.58.0",
-    "@typescript-eslint/parser": "^5.58.0",
+    "@typescript-eslint/eslint-plugin": "^8.57.0",
+    "@typescript-eslint/parser": "^8.57.0",
     "esbuild": "^0.17.16",
     "esbuild-register": "^3.4.2",
-    "eslint": "^7.32.0",
-    "eslint-import-resolver-typescript": "^3.5.5",
-    "eslint-plugin-import": "^2.27.5",
+    "eslint": "^8.57.1",
+    "eslint-import-resolver-typescript": "^3.6.3",
+    "eslint-plugin-import": "^2.32.0",
     "husky": "^7.0.4",
     "jest": "^29.5.0",
     "jest-config": "^29.5.0",

packages/benchmark.js-plugin/benches/sample.ts

@@ -16,6 +16,7 @@ suite
     /o/.test("Hello World!");
   })
   .add("String#indexOf", function () {
+    // eslint-disable-next-line @typescript-eslint/no-unused-expressions
     "Hello World!".indexOf("o") > -1;
   })
   .add("short body", () => {

packages/benchmark.js-plugin/src/buildSuiteAdd.ts

@@ -22,10 +22,10 @@ export default function buildSuiteAdd(suite: Suite) {
   }
 
   function add(options: Options): Suite;
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   function add(fn: Function, options?: Options): Suite;
   function add(name: string, options?: Options): Suite;
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   function add(name: string, fn: Function, options?: Options): Suite;
   function add(name: unknown, fn?: unknown, opts?: unknown) {
     // 1 argument: (options: Options)

packages/core/src/native_core/index.ts

@@ -13,7 +13,7 @@ interface NativeCoreWithBindingStatus extends NativeCore {
 
 let native_core: NativeCoreWithBindingStatus;
 try {
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const nativeCore = require("node-gyp-build")(
     path.dirname(__dirname),
   ) as NativeCore;

packages/core/tests/index.integ.test.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
+/* eslint-disable @typescript-eslint/no-require-imports */
 export {}; // Make this a module
 
 beforeEach(() => {