feat: process raw results while running benchmarks

Author: not-matthias

go-runner/src/lib.rs

@@ -39,6 +39,7 @@ pub fn run_benchmarks<P: AsRef<Path>>(
 
     // 2. Generate codspeed runners, build binaries, and execute them
     let templater = Templater::new();
+    let mut threads = Vec::with_capacity(packages.len());
     for package in &packages {
         info!("Generating custom runner for package: {}", package.name);
         let ctx = templater.run(package, &profile_dir)?;
@@ -65,15 +66,23 @@ pub fn run_benchmarks<P: AsRef<Path>>(
                 error!("Failed to run benchmarks for {}: {error}", package.name);
                 continue;
             }
+
+            // Collect the results in a new thread, to avoid blocking the main thread at the end. The
+            // conversions and computations can take a while when we have a lot of iterations.
+            let profile_dir = profile_dir.as_ref().to_path_buf();
+            threads.push(std::thread::spawn(move || {
+                collect_walltime_results(profile_dir.as_ref()).unwrap();
+            }));
         } else {
             info!("Skipping benchmark execution (dry-run mode)");
         }
     }
 
-    // 3. Collect the results
-    if !cli.dry_run {
-        collect_walltime_results(profile_dir.as_ref())?;
-    }
+    // Wait for all result collection threads to finish
+    threads.into_iter().for_each(|t| {
+        t.join()
+            .expect("Failed to join collect_walltime_results thread")
+    });
 
     Ok(())
 }
@@ -90,11 +99,6 @@ pub fn collect_walltime_results(profile_dir: &Path) -> anyhow::Result<()> {
             .push(walltime_result);
     }
 
-    // Remove raw results directory after processing to save space
-    if raw_results_dir.exists() {
-        std::fs::remove_dir_all(&raw_results_dir)?;
-    }
-
     for (pid, walltime_benchmarks) in benchmarks_by_pid {
         let creator = results::walltime_results::Creator {
             name: "codspeed-go".into(),

go-runner/src/results/raw_result.rs

@@ -23,19 +23,27 @@ impl RawResult {
             .par_bridge()
             .filter_map(Result::ok)
             .filter_map(|path| {
-                let file = std::fs::File::open(&path).ok()?;
-                let reader = std::io::BufReader::new(file);
-                let json: Self = serde_json::from_reader(reader).ok()?;
-                Some((
-                    json.pid,
-                    WalltimeBenchmark::from_runtime_data(
-                        json.name,
-                        json.uri,
-                        &json.codspeed_iters_per_round,
-                        &json.codspeed_time_per_round_ns,
-                        None,
-                    ),
-                ))
+                let (pid, bench) = {
+                    let file = std::fs::File::open(&path).ok()?;
+                    let reader = std::io::BufReader::new(file);
+                    let json: Self = serde_json::from_reader(reader).ok()?;
+
+                    (
+                        json.pid,
+                        WalltimeBenchmark::from_runtime_data(
+                            json.name,
+                            json.uri,
+                            &json.codspeed_iters_per_round,
+                            &json.codspeed_time_per_round_ns,
+                            None,
+                        ),
+                    )
+                };
+
+                // Remove the file since we processed it
+                std::fs::remove_file(path).ok();
+
+                Some((pid, bench))
             })
             .collect();
         Ok(result)