Skip to content

Commit 9d54eab

Browse files
committed
fixup! feat(bench): add Darwin-specific fib variant for macOS flamegraph coverage
1 parent d97ef91 commit 9d54eab

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -224,10 +224,8 @@ jobs:
224224
225225
- name: Run the benchmarks
226226
uses: CodSpeedHQ/action@main
227-
env:
228-
CODSPEED_SKIP_UPLOAD: "true"
229227
with:
230-
run: examples/google_benchmark_cmake/build/benchmark_example --benchmark_filter=Fibo
228+
run: examples/google_benchmark_cmake/build/benchmark_example --benchmark_filter=^BM_FibonacciRecursive_Darwin$
231229
mode: walltime
232230
# TODO: Remove this once the runner has been released with macos support
233231
runner-version: branch:main
@@ -252,14 +250,10 @@ jobs:
252250
253251
- name: Run the benchmarks
254252
uses: CodSpeedHQ/action@main
255-
env:
256-
CODSPEED_SKIP_UPLOAD: "true"
257253
with:
258254
# Note: using bazel run directly fails with a permission error on `/var/tmp/_bazel_codspeed/`
259255
# This is because bazel does not like the user switch between running `bazel build` as a user then running `bazel run` as sudo and refuses to run.
260256
# For now, `$USER` remains the original user, but the program is ran with uid 0 with `sudo --preserve-env`
261257
# This problem is temporary because the runner does not YET do the same uid/gid spoofing on macos as it does on linux.
262-
run: ./bazel-bin/examples/google_benchmark_bazel/my_benchmark --benchmark_filter=Fibo
258+
run: ./bazel-bin/examples/google_benchmark_bazel/my_benchmark --benchmark_filter=^BM_FibonacciRecursive_Darwin$
263259
mode: walltime
264-
# TODO: Remove this once the runner has been released with macos support
265-
runner-version: branch:main

0 commit comments

Comments
 (0)