Commit e3a40e5
committed
fix: Address code review feedback and finalize template
This commit resolves the issues identified during the code review to finalize the Python package template.
Key fixes include:
- **Dockerfile Improvement:** The runtime stage of the `Dockerfile` now adds the non-root user's local bin directory to the `PATH` environment variable. This ensures that any command-line scripts installed by dependencies are directly accessible, preventing potential runtime errors.
- **CI Optimization:** The redundant `lint-docker` job has been removed from the `ci.yml` workflow. Dockerfile linting is already handled comprehensively by the `hadolint` hook within the main `lint` job's `pre-commit` execution, making the separate job unnecessary and streamlining the CI process.1 parent c682925 commit e3a40e5
2 files changed
Lines changed: 4 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | 41 | | |
51 | | - | |
| 42 | + | |
52 | 43 | | |
53 | 44 | | |
54 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
| |||
0 commit comments