Add server version in the Status. Add warnings on replica version divergence. (#116)

GrigoryPervakov · scanhex12 · commit 6e25096e7b9d · 2026-03-19T13:39:48.000+01:00
diff --git a/api/v1alpha1/conditions.go b/api/v1alpha1/conditions.go
@@ -52,7 +52,6 @@ const (
 	ConditionReasonMajorUpdateAvailable ConditionReason = "MajorUpdateAvailable"
 	ConditionReasonVersionOutdated      ConditionReason = "VersionOutdated"
 	ConditionReasonUpgradeCheckFailed   ConditionReason = "UpgradeCheckFailed"
-
 	// ConditionTypeReady indicates that cluster is ready to serve client requests.
 	ConditionTypeReady                      ConditionType   = "Ready"
 	ClickHouseConditionAllShardsReady       ConditionReason = "AllShardsReady"
diff --git a/internal/controller/clickhouse/sync.go b/internal/controller/clickhouse/sync.go
@@ -732,7 +732,6 @@ func (r *clickhouseReconciler) reconcileConditions(ctx context.Context, log ctrl
 	if err := r.UpdateUpgradeCondition(ctx, log, r.versionProbe, r.Cluster.Spec.UpgradeChannel); err != nil {
 		return nil, fmt.Errorf("update VersionUpgraded condition: %w", err)
 	}
-
 	exists := len(r.ReplicaState)
 	expected := int(r.Cluster.Replicas() * r.Cluster.Shards())
 
diff --git a/internal/controller/keeper/sync.go b/internal/controller/keeper/sync.go
@@ -647,7 +647,6 @@ func (r *keeperReconciler) reconcileConditions(ctx context.Context, log ctrlutil
 	if err := r.UpdateUpgradeCondition(ctx, log, r.versionProbe, r.Cluster.Spec.UpgradeChannel); err != nil {
 		return nil, fmt.Errorf("update VersionUpgraded condition: %w", err)
 	}
-
 	exists := len(r.ReplicaState)
 	expected := int(r.Cluster.Replicas())
 

Original file line number	Diff line number	Diff line change
`@@ -732,7 +732,6 @@ func (r *clickhouseReconciler) reconcileConditions(ctx context.Context, log ctrl`
`732`	`732`	`if err := r.UpdateUpgradeCondition(ctx, log, r.versionProbe, r.Cluster.Spec.UpgradeChannel); err != nil {`
`733`	`733`	`return nil, fmt.Errorf("update VersionUpgraded condition: %w", err)`
`734`	`734`	`}`
`735`		`-`
`736`	`735`	`exists := len(r.ReplicaState)`
`737`	`736`	`expected := int(r.Cluster.Replicas() * r.Cluster.Shards())`
`738`	`737`
Original file line number	Diff line number	Diff line change
`@@ -647,7 +647,6 @@ func (r *keeperReconciler) reconcileConditions(ctx context.Context, log ctrlutil`
`647`	`647`	`if err := r.UpdateUpgradeCondition(ctx, log, r.versionProbe, r.Cluster.Spec.UpgradeChannel); err != nil {`
`648`	`648`	`return nil, fmt.Errorf("update VersionUpgraded condition: %w", err)`
`649`	`649`	`}`
`650`		`-`
`651`	`650`	`exists := len(r.ReplicaState)`
`652`	`651`	`expected := int(r.Cluster.Replicas())`
`653`	`652`