Skip to content

Commit e415373

Browse files
authored
Merge pull request #106 from ClickHouse/lz4
Remove ClickHouse LZ4 config
2 parents 478950c + c3e9ccd commit e415373

16 files changed

+24
-966
lines changed

clickhouse/create_and_load.sh

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,20 @@
11
#!/bin/bash
22

33
# Check if the required arguments are provided
4-
if [[ $# -lt 7 ]]; then
5-
echo "Usage: $0 <DB_NAME> <TABLE_NAME> <DDL_FILE> <DATA_DIRECTORY> <NUM_FILES> <SUCCESS_LOG> <ERROR_LOG>"
4+
if [[ $# -lt 6 ]]; then
5+
echo "Usage: $0 <DB_NAME> <TABLE_NAME> <DATA_DIRECTORY> <NUM_FILES> <SUCCESS_LOG> <ERROR_LOG>"
66
exit 1
77
fi
88

99
# Arguments
1010
DB_NAME="$1"
1111
TABLE_NAME="$2"
12-
DDL_FILE="$3"
13-
DATA_DIRECTORY="$4"
14-
NUM_FILES="$5"
15-
SUCCESS_LOG="$6"
16-
ERROR_LOG="$7"
12+
DATA_DIRECTORY="$3"
13+
NUM_FILES="$4"
14+
SUCCESS_LOG="$5"
15+
ERROR_LOG="$6"
1716

1817
# Validate arguments
19-
[[ ! -f "$DDL_FILE" ]] && { echo "Error: DDL file '$DDL_FILE' does not exist."; exit 1; }
2018
[[ ! -d "$DATA_DIRECTORY" ]] && { echo "Error: Data directory '$DATA_DIRECTORY' does not exist."; exit 1; }
2119
[[ ! "$NUM_FILES" =~ ^[0-9]+$ ]] && { echo "Error: NUM_FILES must be a positive integer."; exit 1; }
2220

@@ -25,7 +23,7 @@ echo "Creating database $DB_NAME"
2523
./clickhouse client --query "CREATE DATABASE IF NOT EXISTS $DB_NAME"
2624

2725
echo "Executing DDL for database $DB_NAME"
28-
./clickhouse client --database="$DB_NAME" --enable_json_type=1 --multiquery < "$DDL_FILE"
26+
./clickhouse client --database="$DB_NAME" --enable_json_type=1 --multiquery < ddl.sql
2927

3028
echo "Loading data for database $DB_NAME"
3129
./load_data.sh "$DATA_DIRECTORY" "$DB_NAME" "$TABLE_NAME" "$NUM_FILES" "$SUCCESS_LOG" "$ERROR_LOG"

clickhouse/ddl_lz4.sql

Lines changed: 0 additions & 15 deletions
This file was deleted.

clickhouse/main.sh

Lines changed: 17 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -36,51 +36,42 @@ fi
3636

3737
benchmark() {
3838
local size=$1
39-
local suffix=$2
4039
# Check DATA_DIRECTORY contains the required number of files to run the benchmark
4140
file_count=$(find "$DATA_DIRECTORY" -type f | wc -l)
4241
if (( file_count < size )); then
4342
echo "Error: Not enough files in '$DATA_DIRECTORY'. Required: $size, Found: $file_count."
4443
exit 1
4544
fi
4645
./start.sh
47-
./create_and_load.sh "bluesky_${size}m_${suffix}" bluesky "ddl_${suffix}.sql" "$DATA_DIRECTORY" "$size" "$SUCCESS_LOG" "$ERROR_LOG"
48-
./total_size.sh "bluesky_${size}m_${suffix}" bluesky | tee "${OUTPUT_PREFIX}_bluesky_${size}m_${suffix}.total_size"
49-
./data_size.sh "bluesky_${size}m_${suffix}" bluesky | tee "${OUTPUT_PREFIX}_bluesky_${size}m_${suffix}.data_size"
50-
./index_size.sh "bluesky_${size}m_${suffix}" bluesky | tee "${OUTPUT_PREFIX}_bluesky_${size}m_${suffix}.index_size"
51-
./count.sh "bluesky_${size}m_${suffix}" bluesky | tee "${OUTPUT_PREFIX}_bluesky_${size}m_${suffix}.count"
52-
#./query_results.sh "bluesky_${size}m_${suffix}" | tee "${OUTPUT_PREFIX}_bluesky_${size}m_${suffix}.query_results"
53-
./index_usage.sh "bluesky_${size}m_${suffix}" | tee "${OUTPUT_PREFIX}_bluesky_${size}m_${suffix}.index_usage"
54-
./physical_query_plans.sh "bluesky_${size}m_${suffix}" | tee "${OUTPUT_PREFIX}_bluesky_${size}m_${suffix}.physical_query_plans"
55-
./benchmark.sh "bluesky_${size}m_${suffix}" "${OUTPUT_PREFIX}_bluesky_${size}m_${suffix}.results_runtime"
46+
./create_and_load.sh "bluesky_${size}m" bluesky "$DATA_DIRECTORY" "$size" "$SUCCESS_LOG" "$ERROR_LOG"
47+
./total_size.sh "bluesky_${size}m" bluesky | tee "${OUTPUT_PREFIX}_bluesky_${size}m.total_size"
48+
./data_size.sh "bluesky_${size}m" bluesky | tee "${OUTPUT_PREFIX}_bluesky_${size}m.data_size"
49+
./index_size.sh "bluesky_${size}m" bluesky | tee "${OUTPUT_PREFIX}_bluesky_${size}m.index_size"
50+
./count.sh "bluesky_${size}m" bluesky | tee "${OUTPUT_PREFIX}_bluesky_${size}m.count"
51+
#./query_results.sh "bluesky_${size}m" | tee "${OUTPUT_PREFIX}_bluesky_${size}m.query_results"
52+
./index_usage.sh "bluesky_${size}m" | tee "${OUTPUT_PREFIX}_bluesky_${size}m.index_usage"
53+
./physical_query_plans.sh "bluesky_${size}m" | tee "${OUTPUT_PREFIX}_bluesky_${size}m.physical_query_plans"
54+
./benchmark.sh "bluesky_${size}m" "${OUTPUT_PREFIX}_bluesky_${size}m.results_runtime"
5655
./drop_table.sh # also stops ClickHouse
5756
}
5857

5958
case $CHOICE in
6059
2)
61-
benchmark 10 lz4
62-
benchmark 10 zstd
60+
benchmark 10
6361
;;
6462
3)
65-
benchmark 100 lz4
66-
benchmark 100 zstd
63+
benchmark 100
6764
;;
6865
4)
69-
benchmark 1000 lz4
70-
benchmark 1000 zstd
66+
benchmark 1000
7167
;;
7268
5)
73-
benchmark 1 lz4
74-
benchmark 1 zstd
75-
benchmark 10 lz4
76-
benchmark 10 zstd
77-
benchmark 100 lz4
78-
benchmark 100 zstd
79-
benchmark 1000 lz4
80-
benchmark 1000 zstd
69+
benchmark 1
70+
benchmark 10
71+
benchmark 100
72+
benchmark 1000
8173
;;
8274
*)
83-
benchmark 1 lz4
84-
benchmark 1 zstd
75+
benchmark 1
8576
;;
8677
esac

clickhouse/results/_index_usage/_m6i.8xlarge_bluesky_1000m_lz4.index_usage

Lines changed: 0 additions & 100 deletions
This file was deleted.

clickhouse/results/_index_usage/_m6i.8xlarge_bluesky_100m_lz4.index_usage

Lines changed: 0 additions & 100 deletions
This file was deleted.

0 commit comments

Comments
 (0)