Merge pull request #4 from naseif/main

Refactoring

Author: stho32

Source/optimalDb/optimalDb.WinForms/MainForm.cs

@@ -15,147 +15,104 @@ public MainForm()
             InitializeComponent();
         }
 
-        protected List<DatabaseConnection> localConnections;
+        protected List<DatabaseConnection> localConnections = new List<DatabaseConnection>();
 
         private void openToolStripMenuItem_Click(object sender, EventArgs e)
         {
 
             if (openFileDialog1.ShowDialog() == DialogResult.OK)
             {
                 var content = File.ReadAllText(openFileDialog1.FileName);
-                JArray configArray = JArray.Parse(content);
 
-                if (localConnections == null)
-
-                {
-                    localConnections = new List<DatabaseConnection>();
-                } 
-
-                if (this.localConnections.Count() != 0)
-                {
-                    // We want to clear the connections list in case a new config was imported and update the combobox
-                    this.localConnections.Clear();
-                    connectionsComboBox.Items.Clear();
-                }
-
-
-
-                foreach (JObject item in configArray) 
-
-                {
-                    string name = item.GetValue("Name").ToString();
-                    string connectionString = item.GetValue("ConnectionString").ToString();
-
-                    if (connectionString == null || connectionString == "")
-                    {
-                        continue;
-                    }
-                    
-
-                    if (!connectionString.StartsWith("Server"))
-                    {
-                        continue;
-                    }
-
-                    localConnections.Add(new DatabaseConnection(name, connectionString));
-                }
-
-
-                for (var i = 0; i < localConnections.Count; i++)
-                {
-                    connectionsComboBox.Items.Add(localConnections[i].Name);
-                }
+                this.localConnections.Clear();
 
+#pragma warning disable CS8604 // Possible null reference argument.
+                localConnections.AddRange(JsonConvert.DeserializeObject<DatabaseConnection[]>(content));
+#pragma warning restore CS8604 // Possible null reference argument.
 
+                UpdateConnectionCombobox();
             }
         }
 
         private void testButton_Click(object sender, EventArgs e)
         {
             DataTable alleViews;
 
-            string selected = this.connectionsComboBox.GetItemText(this.connectionsComboBox.SelectedItem);
-            string connectionString = "";
-
-
-            if (selected == "")
-            {
-                MessageBox.Show("You have to select a database to test!", "No Databse selected", MessageBoxButtons.OK, MessageBoxIcon.Error);
-                return;
-            }
-            
-
-            if (localConnections.Count != 0)
-            {
-                connectionString = localConnections.Find(connection => connection.Name.Equals(selected)).ConnectionString;
-            }
+            var selected = connectionsComboBox.SelectedItem as DatabaseConnection;
 
-            if (connectionString == "")
+            if (selected == null)
             {
-                MessageBox.Show("A SQL Database connection URL was not found for the selected Database, make sure this Database has a valid connection URL", "Connection Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
+                MessageBox.Show("You have to select a database to test!", "No Database selected", MessageBoxButtons.OK, MessageBoxIcon.Error);
                 return;
             }
 
-            using (SqlConnection connection = new SqlConnection(connectionString))
+            try
             {
-                connection.Open();
+                using (SqlConnection connection = new SqlConnection(selected.ConnectionString))
+                {
+                    connection.Open();
 
-                var sql = @"
+                    var sql = @"
                            SELECT t.TABLE_SCHEMA, t.TABLE_NAME
                             FROM INFORMATION_SCHEMA.TABLES t
                             WHERE t.TABLE_TYPE = 'VIEW'";
 
-                using (SqlCommand command = new SqlCommand(sql, connection))
-                {
-                    SqlDataAdapter adapter = new SqlDataAdapter(command);
-                    DataSet dataset = new DataSet();
-                    adapter.Fill(dataset);
-                    connection.Close();
-                    alleViews = dataset.Tables[0];
+                    using (SqlCommand command = new SqlCommand(sql, connection))
+                    {
+                        SqlDataAdapter adapter = new SqlDataAdapter(command);
+                        DataSet dataset = new DataSet();
+                        adapter.Fill(dataset);
+                        connection.Close();
+                        alleViews = dataset.Tables[0];
+                    }
                 }
-            }
 
-            var result = new List<ViewPerformanceTestResult>();
+                var result = new List<ViewPerformanceTestResult>();
 
-            foreach(DataRow row in alleViews.Rows)
-            {
-                result.Add(
-                    new ViewPerformanceTestResult(
-                        row["TABLE_SCHEMA"].ToString() + "." + row["TABLE_NAME"].ToString(),
-                        GetDurationOfViewExecution(row["TABLE_SCHEMA"].ToString() + "." + row["TABLE_NAME"].ToString(), connectionString)
-                    ));
+                foreach (DataRow row in alleViews.Rows)
+                {
+                    result.Add(
+                        new ViewPerformanceTestResult(
+                            row["TABLE_SCHEMA"].ToString() + "." + row["TABLE_NAME"].ToString(),
+                            GetDurationOfViewExecution(row["TABLE_SCHEMA"].ToString() + "." + row["TABLE_NAME"].ToString(), selected.ConnectionString)
+                        ));
 
-            }
-            dataGridView1.DataSource = result;
+                }
+                dataGridView1.DataSource = result;
 
-            int columnCount = dataGridView1.Columns.Count;
-            decimal warning = 5;
-            decimal error = 25;
+                int columnCount = dataGridView1.Columns.Count;
+                decimal warning = 5;
+                decimal error = 25;
 
-            for (int i = 1; (i - 1) < dataGridView1.Rows.Count; i++)
-            {
-                for (int j = 0; j < columnCount; j++)
+                for (int i = 1; (i - 1) < dataGridView1.Rows.Count; i++)
                 {
-                    if (dataGridView1.Rows[i - 1].Cells[j].Value.GetType() == typeof(decimal))
+                    for (int j = 0; j < columnCount; j++)
                     {
-                        decimal value;
-                        if (Decimal.TryParse(dataGridView1.Rows[i - 1].Cells[j].Value.ToString(), out value) && value >= warning)
+                        if (dataGridView1.Rows[i - 1].Cells[j].Value.GetType() == typeof(decimal))
                         {
+                            decimal value;
+                            if (Decimal.TryParse(dataGridView1.Rows[i - 1].Cells[j].Value.ToString(), out value) && value >= warning)
+                            {
 
-                            dataGridView1.Rows[i - 1].Cells[j].Style.BackColor = Color.Yellow;
+                                dataGridView1.Rows[i - 1].Cells[j].Style.BackColor = Color.Yellow;
 
-                        } 
-                        else if (Decimal.TryParse(dataGridView1.Rows[i - 1].Cells[j].Value.ToString(), out value) && value >= error) 
-                        {
+                            }
+                            else if (Decimal.TryParse(dataGridView1.Rows[i - 1].Cells[j].Value.ToString(), out value) && value >= error)
+                            {
 
-                            dataGridView1.Rows[i - 1].Cells[j].Style.BackColor = Color.Red;
+                                dataGridView1.Rows[i - 1].Cells[j].Style.BackColor = Color.Red;
 
-                        }
+                            }
 
+                        }
                     }
                 }
-            }
 
+            }
+            catch (Exception ex)
+            {
+                MessageBox.Show(ex.Message);
+            }
 
         }
 
@@ -220,19 +177,17 @@ public void ShowCreateDialog()
             prompt.AcceptButton = confirmation;
 
             if (prompt.ShowDialog() == DialogResult.OK )
-
             {
-
-                if (localConnections == null)
-                {
-                    localConnections = new List<DatabaseConnection>();
-                }
-
                 localConnections.Add(new DatabaseConnection(databasetextBox.Text, urltextbox.Text));
-                connectionsComboBox.Items.Add(databasetextBox.Text.ToString());
-
+                UpdateConnectionCombobox();
             }
+        }
 
+        private void UpdateConnectionCombobox()
+        {
+            connectionsComboBox.DataSource = localConnections.ToArray();
+            connectionsComboBox.ValueMember = "ConnectionString";
+            connectionsComboBox.DisplayMember = "Name";
         }
 
         private void saveToolStripMenuItem_Click(object sender, EventArgs e)