A Crash Issue

[PurusClm]

Problem Description

The game crashes whenever I tried to add coal liquefaction recipe by clicking the coal by-product icon, coming from any recipe that gives multiple outputs including coal. I haven't found any other way to cause the same crash beyond this scope. The error message can be found in the attachment.

Reproduction

No response

[rjgotten]

It's because of c6b8404
Specifically line 113 and line 114:

local proto = prototyper.util.find("items", modal_data.product_id, modal_data.category_id)
line.recipe.temperatures[proto.base_name] = proto.temperature

this is missing a conditional check for proto.temperature.
Only values that define a temperature have a base_name. Others only have a name.

Ergo

local proto = prototyper.util.find("items", modal_data.product_id, modal_data.category_id)
if proto.temperature then
  line.recipe.temperatures[proto.base_name] = proto.temperature
end

I've patched this locally and it works.
I think only fluids define temperature and have base_name, so this would probably cause a looo---t of crashes with recipes in byproduct-heavy mods that don't limit them to just fluids.

[dodgex]

The fix suggested by @rjgotten seems to work for me, at least I can once again add receipts using by-products \o/.

[ClaudeMetz]

Thanks for the report, and indeed the correct fix! Nicely done. Fixed for the next release, sorry for the wait.