Efficieny modules in beacons affect recipes that don't allow efficiency

[CodesInChaos]

FactoryPlanner 2.0.44 with the Krastorio 2 + Space Exploration mods, the Water Separation recipe in the Electrolysis Plant doesn't accept efficiency modules. In-game a beacon containing efficiency modules does not reduce its power consumption either. In the planner it does.

[rjgotten]

Iirc Space Exploration changes the Krastorio 2 Electrolysis Plant building itself to as a whole not accept efficiency effects for anything, rather than just changing its known recipes. It's a heavy-handed but otherwise hands-off solution. Should K2 ever add more recipes there, it won't need further adjusting from the SE side again to disallow efficiency effects on those as well.

What this means for Factory Planner though, is that it currently does not pick up those blocked effects when configuring a beacon on an Electrolysis Plant. Factory Planner's ModuleSet:check_compatibility method checks the recipe and the entity for compatibility of effects and categories - but for beacons, the entity that it checks is the beacon itself. Not the factory building. And beacons of course, continue to allow for efficiency modules in general.

For the case where the player configures modules for a beacon, Factory Planner should actually be checking all three: the factory building; the beacon; and the recipe. All three can filter on allowed effects and allowed module categories.

(Yeah... I kind of ran into this as well. And then I started digging into the mod's code to figure out what caused it.)