[alert/timer/client] SignedOn unsafe for admin_reload

[gkistler]

Modules need a hook that provides functionality that isn't currently provided by SetupContainer. In pbm_alert's case I ran into an issue where I needed to create a looping timer that queried a database; this isn't currently supported.

Digging in I found that the most direct way to add this functionality would be to simply extend SetupContainer and add query functionality for use in module inits. For the time being I do like how SetupContainer provides reactor-thread-safe versions of Container's methods.

I'm thinking that's what I'll do for now until we address how deeply coupled Factory/Settings/Container/Dispatcher are.

Alternatively I can simply fire a fake SignedOn event on reload/etc, but that seems less intuitive to me.

[Clam-]

SetupContainer.container might be what you are after? Your .addtimer call could probably be something like:

def init(bot):
    ...
    Timers.addtimer(TIMER_NAME, LOOP_INTERVAL, check_alerts_callback, reps=-1, startnow=False, bot=bot.container)

Just be aware that multiple servers can share the same "database." This might mean that the module in it's current form doesn't act like you might think. I don't think anyone uses that functionality at this point in time though (mainly because I don't currently connect to multiple servers, lol.)
By default multiple servers will share a single database. If you are curious how that works: DBManager._addServer