Phase 26: Fix all failed smoke tests

Fixed 6 failing tests by addressing missing waits and credentials:

1. **test_prv_001_login**: Added test_credentials fixture parameter
   - Error: TypeError 'NoneType' not iterable (email was None)
   - Fix: Pass email/password from test_credentials fixture

2. **test_prv_003, 004, 007, 008** (UseCase tests): Added wait after clicking "Add New UseCase"
   - Error: TimeoutException "Could not find UseCase summary textarea"
   - Fix: Wait for summary textarea to load in click_add_new_usecase()

3. **test_prv_009_org_edit_profile**: Added wait after clicking Profile link
   - Error: TimeoutException on profile page load
   - Fix: Wait for "My Profile" heading to load

Additional improvements:
- Added waits in click_usecases_card() for both MyDashboard and Organizations pages
- Added waits in click_profile_card() for both MyDashboard and Organizations pages
- Ensures all navigation methods wait for target pages to fully load before returning

Author: Saqib

login_step_fill_credentials_FAIL.png

@@ -133,15 +133,33 @@ def click_add_new_dataset(self) -> CreateDatasetPage:
         return CreateDatasetPage(self.driver)
 
     def click_usecases_card(self):
+        from locators.provider.usecases_list_page_locators import UseCaseListPageLocators
+
         self.wait_with_timeout(10).until(
             EC.element_to_be_clickable(MyDashboardLocators.USECASES_NAV_LINK),
             message="Timed out waiting for the 'Usecases' card to be clickable"
         ).click()
+
+        # Wait for the UseCases page to load by checking for the "Add New UseCase" button
+        self.wait_with_timeout(10).until(
+            EC.visibility_of_element_located(UseCaseListPageLocators.ADD_NEW_USECASE_BUTTON),
+            message="Timed out waiting for UseCases page to load"
+        )
+
         return UseCasesListPage(self.driver)
 
     def click_profile_card(self):
+        from locators.provider.update_profile_locators import UpdateProfilePageLocators
+
         self.wait_with_timeout(10).until(
             EC.element_to_be_clickable(MyDashboardLocators.PROFILE_NAV_LINK),
             message="Timed out waiting for the 'Profile' card to be clickable"
         ).click()
+
+        # Wait for the profile page to load by checking for the "My Profile" heading
+        self.wait_with_timeout(10).until(
+            EC.visibility_of_element_located(UpdateProfilePageLocators.My_Profile_HEADING),
+            message="Timed out waiting for Profile page to load"
+        )
+
         return UpdateProfilePage(self.driver)

pages/provider/my_dashboard_page.py

@@ -116,12 +116,19 @@ def click_usecases_card(self):
         Returns a UseCasesListPage instance.
         """
         from pages.provider.usecases_list_page import UseCasesListPage
+        from locators.provider.usecases_list_page_locators import UseCaseListPageLocators
 
         self.wait_with_timeout(10).until(
             EC.element_to_be_clickable(OrgLocators.USECASES_NAV_LINK),
             message="Timed out waiting for the 'UseCases' link to be clickable"
         ).click()
 
+        # Wait for the UseCases page to load by checking for the "Add New UseCase" button
+        self.wait_with_timeout(10).until(
+            EC.visibility_of_element_located(UseCaseListPageLocators.ADD_NEW_USECASE_BUTTON),
+            message="Timed out waiting for UseCases page to load"
+        )
+
         return UseCasesListPage(self.driver)
 
     def click_profile_card(self):
@@ -134,10 +141,17 @@ def click_profile_card(self):
         Returns an UpdateProfilePage instance.
         """
         from pages.provider.update_profile_page import UpdateProfilePage
+        from locators.provider.update_profile_locators import UpdateProfilePageLocators
 
         self.wait_with_timeout(10).until(
             EC.element_to_be_clickable(OrgLocators.PROFILE_NAV_LINK),
             message="Timed out waiting for the 'Profile' link to be clickable"
         ).click()
 
+        # Wait for the profile page to load by checking for the "My Profile" heading
+        self.wait_with_timeout(10).until(
+            EC.visibility_of_element_located(UpdateProfilePageLocators.My_Profile_HEADING),
+            message="Timed out waiting for Profile page to load"
+        )
+
         return UpdateProfilePage(self.driver)

pages/provider/organizations_page.py

@@ -5,6 +5,7 @@
 from pages.base_page import BasePage
 from pages.provider.create_usecase_page import CreateUsecasePage
 from locators.provider.usecases_list_page_locators import UseCaseListPageLocators
+from locators.provider.create_usecase_locators import CreateUsecaseLocators
 
 
 class UseCasesListPage(BasePage):
@@ -18,6 +19,19 @@ def is_loaded(self):
         )
 
     def click_add_new_usecase(self):
+        """
+        Click the "Add New UseCase" button and wait for the create usecase form to load.
+
+        Returns:
+            CreateUsecasePage instance after the form has loaded
+        """
         self.driver.find_element(*UseCaseListPageLocators.ADD_NEW_USECASE_BUTTON).click()
+
+        # Wait for the UseCase creation form to load by checking for the summary textarea
+        self.wait_with_timeout(10).until(
+            EC.visibility_of_element_located(CreateUsecaseLocators.USECASE_SUMMARY_INPUT),
+            message="Timed out waiting for UseCase creation form to load"
+        )
+
         return CreateUsecasePage(self.driver)
 

pages/provider/usecases_list_page.py

@@ -0,0 +1,11 @@
+_state_,district,_date,year,month,avg_smlvl_at15cm,_agency_name
+Madhya Pradesh,Vidisha,2023-01-04T10:07:33Z,2023,1,22.4790934997,NRSC VIC MODEL
+Madhya Pradesh,Vidisha,2023-01-08T10:07:33Z,2023,1,22.3545937778,NRSC VIC MODEL
+Madhya Pradesh,Vidisha,2023-01-10T10:07:33Z,2023,1,22.2889593178,NRSC VIC MODEL
+Madhya Pradesh,Vidisha,2023-01-11T10:07:33Z,2023,1,22.2922401219,NRSC VIC MODEL
+Madhya Pradesh,Vidisha,2023-01-15T10:07:33Z,2023,1,22.167213275,NRSC VIC MODEL
+Madhya Pradesh,Vidisha,2023-01-18T10:07:33Z,2023,1,22.0865192788,NRSC VIC MODEL
+Madhya Pradesh,Vidisha,2023-01-19T10:07:33Z,2023,1,22.0589074178,NRSC VIC MODEL
+Madhya Pradesh,Vidisha,2023-01-23T10:07:33Z,2023,1,21.9648621457,NRSC VIC MODEL
+Madhya Pradesh,Vidisha,2023-02-03T10:05:28Z,2023,2,25.7675515718,NRSC VIC MODEL
+Madhya Pradesh,Vidisha,2023-01-01T10:07:33Z,2023,1,22.5548504826,NRSC VIC MODEL

tests/data/sam_create_20260119_175400.csv tests/data/sam_create_20260119_181733.csvtests/data/sam_create_20260119_175400.csv renamed to tests/data/sam_create_20260119_181733.csv

@@ -11,19 +11,20 @@
 
 
 @pytest.mark.smoke
-def test_prv_001_login_smoke(driver, base_url):
+def test_prv_001_login_smoke(driver, base_url, test_credentials):
     # Step 0: ensure a clean session
     driver.delete_all_cookies()
     home = HomePage(driver, base_url)
     home.load()
 
     # Step 1: click LOGIN / SIGN UP and expect a LoginPage
-    prov_home = home.go_to_login(flow="provider")
+    email, password = test_credentials
+    prov_home = home.go_to_login(flow="provider", email=email, password=password)
     # Assert that go_to_login actually returned a ProviderHomePage
     assert isinstance(prov_home, ProviderHomePage), "Did not land on ProviderHomePage"
 
     # Optionally, verify some element on ProviderHomePage is visible:
     WebDriverWait(driver, 5).until(
-        EC.visibility_of_element_located((By.XPATH, ProviderHomepageLocators.HEADER))
+        EC.visibility_of_element_located(ProviderHomepageLocators.HEADER)
     )
     assert prov_home.is_header_visible()