Add option to use external receive tasks#58
Open
mzella-ll wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a compile-time option to disable the internal CoAP receive tasks.
When
USE_EXTERNAL_RECV_TASKSis defined, the CoAP client and server no longer create, cancel, declare, or compile their internal receive tasks. This allows applications or platform integrations to operate the receive handling outside of the library.Changes
USE_EXTERNAL_RECV_TASKS.coapclient_open().coapclient_stop().USE_EXTERNAL_RECV_TASKS.coapserver_listen().coapserver_stop().Motivation
In some deployments, incoming CoAP packets are received by code outside of the library, for example by an application-specific task, event loop, scheduler, or platform integration layer.
In these cases, the library should not create its own receive tasks. The new compile-time macro makes the internal receive task handling optional while preserving the existing behavior by default.
Expected behavior
When
USE_EXTERNAL_RECV_TASKSis not defined, the existing behavior remains unchanged:When
USE_EXTERNAL_RECV_TASKSis defined:Related issue
Fixes #57