Realtime Fixes

Author: ChristianJStarr

.github/release-drafter.yml

@@ -0,0 +1,46 @@
+name-template: 'v$RESOLVED_VERSION'
+tag-template: 'v$RESOLVED_VERSION'
+
+categories:
+  - title: '🚀 Features'
+    labels:
+      - 'feature'
+      - 'enhancement'
+      - 'feat'
+  - title: '🐛 Bug Fixes'
+    labels:
+      - 'bug'
+      - 'fix'
+  - title: '🧰 Maintenance'
+    labels:
+      - 'chore'
+      - 'maintenance'
+      - 'refactor'
+
+change-template: '- $TITLE (#$NUMBER)'
+
+no-changes-template: '- No significant changes.'
+
+version-resolver:
+  major:
+    labels:
+      - 'breaking'
+  minor:
+    labels:
+      - 'feature'
+      - 'enhancement'
+      - 'feat'
+  patch:
+    labels:
+      - 'bug'
+      - 'fix'
+      - 'chore'
+      - 'maintenance'
+      - 'refactor'
+
+exclude-labels:
+  - 'skip-changelog'
+
+template: |
+  ## Changes
+  $CHANGES

.github/workflows/release.yml

@@ -0,0 +1,42 @@
+name: Release
+
+on:
+  push:
+    tags:
+      - 'v*.*.*'
+  pull_request:
+    types: [closed]
+
+jobs:
+  build-and-publish:
+    if: startsWith(github.ref, 'refs/tags/v')
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+
+      - name: Install build tools
+        run: |
+          python -m pip install --upgrade pip build
+
+      - name: Build package
+        run: python -m build
+
+      - name: Publish to PyPI
+        uses: pypa/gh-action-pypi-publish@release/v1
+        with:
+          password: ${{ secrets.PYPI_API_TOKEN }}
+
+  update-release-draft:
+    if: github.event.pull_request.merged == true
+    runs-on: ubuntu-latest
+    steps:
+      - uses: release-drafter/release-drafter@v6
+        with:
+          config-name: release-drafter.yml
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

projectx_sdk/client.py

@@ -33,7 +33,7 @@ class ProjectXClient:
     session management, and request routing.
     """
 
-    # Map of environment names to base URLs
+    # Map of environment names to base URLs (only new endpoints)
     ENVIRONMENT_URLS = {
         "alphaticks": "https://api.alphaticks.projectx.com",
         "blueguardian": "https://api.blueguardianfutures.projectx.com",
@@ -52,7 +52,7 @@ class ProjectXClient:
         "demo": "https://gateway-api-demo.s2f.projectx.com",
     }
 
-    # Map of environment names to user hub URLs
+    # Map of environment names to user hub URLs (only new endpoints)
     USER_HUB_URLS = {
         "alphaticks": "https://rtc.alphaticks.projectx.com/hubs/user",
         "blueguardian": "https://rtc.blueguardianfutures.projectx.com/hubs/user",
@@ -71,7 +71,7 @@ class ProjectXClient:
         "demo": "https://gateway-api-demo.s2f.projectx.com/hubs/user",
     }
 
-    # Map of environment names to market hub URLs
+    # Map of environment names to market hub URLs (only new endpoints)
     MARKET_HUB_URLS = {
         "alphaticks": "https://rtc.alphaticks.projectx.com/hubs/market",
         "blueguardian": "https://rtc.blueguardianfutures.projectx.com/hubs/market",

projectx_sdk/realtime/__init__.py

@@ -94,7 +94,6 @@ def reconnect_subscriptions(self):
         self.market.reconnect_subscriptions()
 
 
-# Class for backward compatibility with tests
 class RealtimeService:
     """
     Legacy service class for real-time communication.
@@ -113,18 +112,8 @@ def __init__(self, client):
         self._client = client
         self._user = None
         self._market = None
-
-        # For backward compatibility with tests, always set base_hub_url
-        self._base_hub_url = f"wss://gateway-rtc-{client.environment}.s2f.projectx.com"
-
-        # Check if we should use the new URL pattern from client.USER_HUB_URLS
-        if hasattr(client, "USER_HUB_URLS") and client.environment in client.USER_HUB_URLS:
-            self._user_hub_url = client.USER_HUB_URLS.get(client.environment)
-            self._market_hub_url = client.MARKET_HUB_URLS.get(client.environment)
-        else:
-            # Fallback to old URL pattern
-            self._user_hub_url = None
-            self._market_hub_url = None
+        self._user_hub_url = client.USER_HUB_URLS.get(client.environment)
+        self._market_hub_url = client.MARKET_HUB_URLS.get(client.environment)
 
     @property
     def user(self):
@@ -135,10 +124,7 @@ def user(self):
             UserHub: The user hub instance
         """
         if self._user is None:
-            if self._user_hub_url:
-                self._user = UserHub(self._client, self._base_hub_url, self._user_hub_url)
-            else:
-                self._user = UserHub(self._client, self._base_hub_url)
+            self._user = UserHub(self._client, None, self._user_hub_url)
         return self._user
 
     @property
@@ -152,10 +138,7 @@ def market(self):
         if self._market is None:
             from projectx_sdk.realtime.market_hub import MarketHub
 
-            if self._market_hub_url:
-                self._market = MarketHub(self._client, self._base_hub_url, self._market_hub_url)
-            else:
-                self._market = MarketHub(self._client, self._base_hub_url)
+            self._market = MarketHub(self._client, None, self._market_hub_url)
         return self._market
 
     def start(self):

tests/test_realtime.py

@@ -16,7 +16,7 @@ def test_init(self, authenticated_client):
         assert service._client == authenticated_client
         assert service._user is None
         assert service._market is None
-        assert service._base_hub_url is not None
+        # _base_hub_url is no longer used or required
 
     def test_user_hub_lazy_loading(self, authenticated_client):
         """Test that the user hub is lazily loaded."""