Skip to content

Commit ac3253b

Browse files
committed
more doc tidying
1 parent a9d4269 commit ac3253b

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

CONTRIBUTING.rst

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,27 +24,30 @@ Clone the repo: ::
2424
$ git clone https://github.com/CenterForOpenScience/modular-file-renderer.git
2525
$ cd modular-file-renderer
2626

27-
Configure development environment and Install the development dependencies.
27+
Configure development environment and install the development dependencies.
2828

2929
.. note::
3030

31-
It is recommended that you use a `virtualenv`_ with `virtualenvwrapper`_ during development. Python 3.5 and R are required.
31+
It is recommended that you use a `virtualenv`_ with `virtualenvwrapper`_ during development. Python 3.5 or greater, `R`_, and `pspp`_ are required.
3232

3333
.. _virtualenv: http://www.virtualenv.org/en/latest/
3434
.. _virtualenvwrapper: https://pypi.python.org/pypi/virtualenvwrapper
35+
.. _R: https://www.r-project.org/
36+
.. _pspp: https://www.gnu.org/software/pspp/
3537

3638
.. code-block:: bash
3739
3840
# For Mac OS X: Install the latest version of python3.5
3941
$ brew install python3
40-
$ brew install r
42+
$ brew install r pspp
4143
4244
# Linux users, probably the same thing but with apt-get
4345
# If someone wants to update this guide, please do.
4446
4547
$ pip install virtualenv
4648
$ pip install virtualenvwrapper
4749
$ mkvirtualenv --python=`which python3` mfr
50+
$ pip install setuptools==30.4.0
4851
$ pip install invoke==0.13.0
4952
5053

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ A Python package for rendering files to HTML via an embeddable iframe.
1010

1111
MFR is compatible with Python 3.5 (tested up to 3.5.3) and 3.6.
1212

13-
1413
### Documentation
1514

1615
Documentation available at: http://modular-file-renderer.readthedocs.io/en/latest/
@@ -83,9 +82,9 @@ invoke install --develop
8382
invoke test
8483
```
8584

86-
### Known Issues
85+
### Known issues
8786

88-
- Running `invoke install -d` with setuptools v31 or greater can break MFR. The symptom error message is: `"AttributeError: module 'mfr' has no attribute '__version__'".` If you encounter this, you will need to remove the file
87+
- Running `invoke install -d` with setuptools v31 or greater can break MFR. The symptom error message is: `"AttributeError: module 'mfr' has no attribute '__version__'".` If you encounter this, you will need to remove the file
8988
`mfr-nspkg.pth` from your virtualenv directory, run `pip install setuptools==30.4.0`, then re-run `invoke install -d`.
9089

9190
- The error `def create_default_context(purpose=ssl.Purpose.SERVER_AUTH, *, cafile=None, capath=None, cadata=None): SyntaxError: invalid syntax` can be fixed by restarting your virtual environment. The problem should not reoccur.
@@ -114,4 +113,4 @@ limitations under the License.
114113

115114
### COS is hiring!
116115

117-
Want to help save science? Want to get paid to develop free, open source software? [Check out our openings!](https://cos.io/jobs/)
116+
Want to help save science? Want to get paid to develop free, open source software? [Check out our openings!](https://cos.io/our-communities/jobs/)

docs/install.rst

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,13 @@ Or download one of the following:
1414
* tarball_
1515
* zipball_
1616

17-
Make sure that you have installed pspp, are using python3.5, and have installed invoke for your current python3 version.
17+
Make sure that you have installed `pspp <https://www.gnu.org/software/pspp/>`_ and are using python 3.5 or greater.
1818

19-
Install the version of invoke found in the requirements.txt file. Currently 0.13.0
20-
21-
Install ``invoke``:
19+
Install the versions of ``setuptools`` and ``invoke`` found in the requirements.txt file:
2220

2321
.. code-block:: bash
2422
23+
pip install setuptools==30.4.0
2524
pip install invoke==0.13.0
2625
2726
Install requirements:

0 commit comments

Comments
 (0)