misc fixes for render size limits

 * fix spelling error in exception name "To" => "Too"

 * error should be a 400, not a 500

 * explicitly cast MAX_SIZE as int in case it comes in as an environment
   variable

 * minor code cleanups

Author: felliott

mfr/extensions/codepygments/exceptions.py

@@ -1,5 +1,6 @@
 from mfr.core.exceptions import RendererError
 
 
-class FileToLargeException(RendererError):
-    pass
+class FileTooLargeException(RendererError):
+    def __init__(self, *args, **kwargs):
+        super().__init__(code=400, *args, **kwargs)

mfr/extensions/codepygments/render.py

@@ -9,8 +9,8 @@
 from pygments.util import ClassNotFound
 from mako.lookup import TemplateLookup
 
-from mfr.extensions.codepygments import settings
 from mfr.core import extension, exceptions
+from mfr.extensions.codepygments import settings
 from mfr.extensions.codepygments import exceptions as cp_exceptions
 
 
@@ -30,7 +30,11 @@ def __init__(self, *args, **kwargs):
     def render(self):
         file_size = os.path.getsize(self.file_path)
         if file_size > settings.MAX_SIZE:
-            raise(cp_exceptions.FileToLargeException('Text files larger than {} are not rendered; please download the file to view.'.format(format_size(settings.MAX_SIZE, binary=True))))
+            raise cp_exceptions.FileTooLargeException(
+                'Text files larger than {} are not rendered. Please download the file to '
+                'view.'.format(format_size(settings.MAX_SIZE, binary=True))
+            )
+
         with open(self.file_path, 'rb') as fp:
             body = self._render_html(fp, self.metadata.ext)
             return self.TEMPLATE.render(base=self.assets_url, body=body)

mfr/extensions/codepygments/settings.py

@@ -2,4 +2,4 @@
 
 config = settings.child('CODEPYGMENTS_EXTENSION_CONFIG')
 
-MAX_SIZE = config.get('MAX_SIZE', 65536)
+MAX_SIZE = int(config.get('MAX_SIZE', 65536))

tests/extensions/codepygments/test_renderer.py

@@ -5,9 +5,8 @@
 from mfr.core.exceptions import RendererError
 from mfr.core.provider import ProviderMetadata
 
-from mfr.extensions.codepygments import CodePygmentsRenderer
-from mfr.extensions.codepygments.exceptions import FileToLargeException
-from mfr.extensions.codepygments import settings
+from mfr.extensions.codepygments import settings, CodePygmentsRenderer
+from mfr.extensions.codepygments.exceptions import FileTooLargeException
 
 
 @pytest.fixture
@@ -93,7 +92,7 @@ def test_render_codepygments_max_size(self, metadata, max_size_file_path, url, a
             os.remove(max_size_file_path)
 
     def test_render_codepygments_over_size(self, metadata, over_size_file_path, url, assets_url, export_url):
-        with pytest.raises(FileToLargeException):
+        with pytest.raises(FileTooLargeException):
             try:
                 renderer = CodePygmentsRenderer(metadata, over_size_file_path,
                                                 url, assets_url, export_url)