[ENG-4008] Unsilence deprecation 'ember-metal.get-with-default' (#1660)

-   Ticket: [ENG-4008]

## Purpose

Fix the deprecations for 'ember-metal.get-with-default' so we can turn off the silencing of that deprecation.

## Summary of Changes

1. Upgrade ember-simple-auth and ember-cp-validations, and pin the resolution of ember-validators because these were the source of the deprecation warnings
2. Fix problems related to upgrading ember-simple-auth, which mostly involved upgrading more addons, overriding a method on ember-simple-auth to keep it from auto-redirecting to index whenever we authed, and fixing some tests.

## Side Effects

My biggest concern is with the upgrade of all of our form validation related addons. Tests are passing, though, so that's good. 

Oh, and we're on node v14 now.

Author: brianjgeiger

app/authenticators/osf-cookie.ts

@@ -86,7 +86,7 @@ export default class OsfCookie extends Base {
         return { id };
     }
 
-    restore() {
+    async restore() {
         const {
             lastVerifiedUserId,
             session: {
@@ -107,7 +107,7 @@ export default class OsfCookie extends Base {
 
         // Check for a valid auth cookie.
         // If it fails, the session will be invalidated.
-        return this.authenticate();
+        return await this.authenticate();
     }
 
     async _checkApiVersion() {

app/decorators/check-auth.ts

@@ -1,10 +1,10 @@
 import Route from '@ember/routing/route';
 import { inject as service, Registry as ServiceRegistry } from '@ember/service';
 import config from 'ember-get-config';
-import SessionService from 'ember-simple-auth/services/session';
 
 import { NotLoggedIn } from 'ember-osf-web/errors';
 import CurrentUser from 'ember-osf-web/services/current-user';
+import OsfSession from 'ember-osf-web/services/session';
 import transitionTargetURL from 'ember-osf-web/utils/transition-target-url';
 
 const {
@@ -30,7 +30,7 @@ export default function checkAuth<T extends ConcreteSubclass<Route>>(
 ) {
     class AuthenticatedRoute extends RouteSubclass {
         @service router!: ServiceRegistry['router'];
-        @service session!: SessionService;
+        @service session!: OsfSession;
         @service currentUser!: CurrentUser;
 
         async beforeModel(transition: any) {

app/services/-private/session.ts

@@ -0,0 +1,8 @@
+
+import SessionService from 'ember-simple-auth/services/session';
+
+export default class OsfSession extends SessionService {
+    handleAuthentication() {
+        return;
+    }
+}

app/services/session.js

@@ -0,0 +1 @@
+export { default } from 'ember-osf-web/services/-private/session';

config/deprecation-workflow.js

@@ -2,7 +2,6 @@ self.deprecationWorkflow = self.deprecationWorkflow || {};
 self.deprecationWorkflow.config = {
     workflow: [
         { handler: 'silence', matchId: 'ember-inflector.globals' },
-        { handler: 'silence', matchId: 'ember-metal.get-with-default' },
         { handler: 'silence', matchId: 'computed-property.volatile' },
         { handler: 'silence', matchId: 'implicit-injections' },
         { handler: 'silence', matchId: 'manager-capabilities.modifiers-3-13' },
@@ -18,5 +17,9 @@ self.deprecationWorkflow.config = {
         { handler: 'silence', matchId: 'ember-engines.deprecation-camelized-engine-names' },
         { handler: 'silence', matchId: 'ember-data:legacy-test-helper-support' },
         { handler: 'silence', matchId: 'has-block-and-has-block-params' },
+        { handler: 'silence', matchId: 'ember-simple-auth.initializer.setup-session-restoration' },
+        { handler: 'silence', matchId: 'ember-simple-auth.events.session-service' },
+        { handler: 'silence', matchId: 'ember-cli-mirage.miragejs.import' },
+        { handler: 'silence', matchId: 'ember-cli-mirage-config-routes-only-export' },
     ],
 };

package.json

@@ -131,8 +131,8 @@
     "ember-cli-htmlbars": "^5.7.1",
     "ember-cli-inject-live-reload": "^2.0.2",
     "ember-cli-inline-content": "0.4.1",
-    "ember-cli-meta-tags": "^6.1.2",
-    "ember-cli-mirage": "^2.0.1",
+    "ember-cli-meta-tags": "^7.0.0",
+    "ember-cli-mirage": "^2.4.0",
     "ember-cli-moment-shim": "^3.5.0",
     "ember-cli-password-strength": "^2.0.0",
     "ember-cli-release": "^1.0.0-beta.2",
@@ -155,15 +155,15 @@
     "ember-concurrency-ts": "^0.2.2",
     "ember-content-placeholders": "https://github.com/cos-forks/ember-content-placeholders#master#2018-07-19",
     "ember-cookies": "^0.4.0",
-    "ember-cp-validations": "https://github.com/GavinJoyce/ember-cp-validations#gj/ember-3.13",
+    "ember-cp-validations": "4.0.0-beta.13",
     "ember-css-modules": "^1.0.3",
     "ember-css-modules-reporter": "^1.2.0",
     "ember-css-modules-sass": "^1.0.1",
     "ember-css-modules-stylelint": "^1.2.0",
     "ember-data": "~3.26.0",
     "ember-decorators": "^6.1.1",
     "ember-diff-attrs": "^0.2.1",
-    "ember-element-helper": "^0.5.5",
+    "ember-element-helper": "^0.6.1",
     "ember-engines": "^0.8.13",
     "ember-event-helpers": "^0.1.0",
     "ember-exam": "^6.0.1",
@@ -192,7 +192,7 @@
     "ember-radio-button": "^2.0.0",
     "ember-resolver": "^8.0.2",
     "ember-responsive": "^3.0.0",
-    "ember-simple-auth": "^2.1.1",
+    "ember-simple-auth": "^4.2.2",
     "ember-sinon": "^5.0.0",
     "ember-sinon-qunit": "^5.0.0",
     "ember-sortable": "2.2",
@@ -228,7 +228,7 @@
     "loaders.css": "^0.1.2",
     "mime-types": "^2.1.22",
     "mocha": "^6.1.4",
-    "node-sass": "^4.13.1",
+    "node-sass": "^4.14.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.2.1",
     "qunit": "^2.14.1",
@@ -245,7 +245,9 @@
   },
   "resolutions": {
     "ember-cli-clipboard": "0.9.0",
-    "@embroider/macros": "^1.0.0"
+    "@embroider/macros": "^1.0.0",
+    "ember-element-helper": "^0.6.1",
+    "ember-validators": "^4.1.1"
   },
   "engines": {
     "node": "10.* || >= 12"
@@ -265,7 +267,7 @@
     ]
   },
   "volta": {
-    "node": "10.18.0",
+    "node": "14.15.0",
     "yarn": "1.21.1"
   },
   "dependencies": {}

tests/integration/components/osf-navbar/component-test.ts

@@ -16,24 +16,30 @@ const routerStub = Service.extend({
     },
 });
 
+const sessionStub = Service.extend({
+    isAuthenticated: false,
+    on: () => { /* stub */ },
+});
+
 module('Integration | Component | osf-navbar', hooks => {
     setupRenderingTest(hooks);
 
     hooks.beforeEach(function(this: TestContext) {
         // Make sure currentURL is always a string
         this.owner.unregister('service:router');
         this.owner.register('service:router', routerStub);
+        this.owner.register('service:session', sessionStub);
     });
 
     test('it renders', async assert => {
-        await render(hbs`{{osf-navbar}}`);
+        await render(hbs`<OsfNavbar />`);
         assert.dom('.service-name').includesText('OSF');
         assert.dom('.current-service').hasText('HOME');
     });
 
     test('service-dropdown: logged in', async function(assert) {
         this.owner.lookup('service:session').set('isAuthenticated', true);
-        await render(hbs`{{osf-navbar}}`);
+        await render(hbs`<OsfNavbar />`);
 
         assert.dom('[data-test-service-dropdown]').exists();
 
@@ -44,7 +50,7 @@ module('Integration | Component | osf-navbar', hooks => {
     test('auth-dropdown: logged in', async function(assert) {
         this.owner.lookup('service:session').set('isAuthenticated', true);
 
-        await render(hbs`{{osf-navbar}}`);
+        await render(hbs`<OsfNavbar />`);
 
         assert.dom('[data-test-auth-dropdown-toggle]').exists();
         await click('[data-test-auth-dropdown-toggle]');
@@ -54,7 +60,7 @@ module('Integration | Component | osf-navbar', hooks => {
     test('osf-navbar: logged out', async function(assert) {
         this.owner.lookup('service:session').set('isAuthenticated', false);
 
-        await render(hbs`{{osf-navbar}}`);
+        await render(hbs`<OsfNavbar />`);
         assert.dom('[data-test-service-dropdown]').exists();
 
         assert.dom('[data-test-auth-dropdown-toggle]').doesNotExist();

tests/integration/components/tos-consent-banner/component-test.ts

@@ -1,3 +1,4 @@
+import Service from '@ember/service';
 import { render } from '@ember/test-helpers';
 import { hbs } from 'ember-cli-htmlbars';
 import { setupMirage } from 'ember-cli-mirage/test-support';
@@ -13,6 +14,12 @@ interface ThisTestContext extends TestContext {
     currentUser: CurrentUser;
 }
 
+const sessionStub = Service.extend({
+    isAuthenticated: false,
+    data: {},
+    on: () => { /* stub */ },
+});
+
 module('Integration | Component | tos-consent-banner', hooks => {
     setupRenderingTest(hooks);
     setupMirage(hooks);
@@ -21,14 +28,17 @@ module('Integration | Component | tos-consent-banner', hooks => {
     hooks.beforeEach(function(this: ThisTestContext) {
         this.store = this.owner.lookup('service:store');
         this.currentUser = this.owner.lookup('service:current-user');
+        this.owner.unregister('service:session');
+        this.owner.register('service:session', sessionStub);
+
     });
 
     hooks.afterEach(() => {
         sandbox.restore();
     });
 
     test('hidden when no user is logged in', async function(assert) {
-        await render(hbs`{{tos-consent-banner}}`);
+        await render(hbs`<TosConsentBanner />`);
         assert.dom(this.element).hasText('');
     });