Merge pull request twilio#154 from philnash/encode-phone-number-lookups

URI encode phone number lookups

Author: philnash

lib/twilio-ruby/rest/lookups/phone_numbers.rb

@@ -6,7 +6,7 @@ class PhoneNumbers < Twilio::REST::NextGenListResource;
         include Twilio::REST::Utils
 
         def get(number, query={})
-          full_path = "#{@path}/#{number}"
+          full_path = "#{@path}/#{URI.encode(number)}"
           full_path << "?#{url_encode(twilify(query))}" if !query.empty?
           @instance_class.new full_path, @client
         end

spec/rest/lookups/phone_number_spec.rb

@@ -5,4 +5,24 @@
     client = Twilio::REST::LookupsClient.new 'otherSid', 'otherToken'
     expect(client).to respond_to(:phone_numbers)
   end
+
+  it 'gets phone numbers without special encoding' do
+    number = '+13123131434'
+    client = Twilio::REST::LookupsClient.new 'otherSid', 'otherToken'
+    expect(client).to receive(:get).once
+      .with('/v1/PhoneNumbers/+13123131434')
+      .and_return({ phone_number: number })
+    phone_number = client.phone_numbers.get('+13123131434').phone_number
+    expect(phone_number).to be(number)
+  end
+
+  it 'URI encodes phone number path parameters' do
+    number = '+13123131434'
+    client = Twilio::REST::LookupsClient.new 'otherSid', 'otherToken'
+    expect(client).to receive(:get).once
+      .with('/v1/PhoneNumbers/+1%20312%20313%201434')
+      .and_return({ phone_number: number })
+    phone_number = client.phone_numbers.get('+1 312 313 1434').phone_number
+    expect(phone_number).to be(number)
+  end
 end