Skip to content

Vault: emit withdraw/withdraw_to events with documented payload shape #246

@greatest0fallt1me

Description

@greatest0fallt1me

Description

Implement the change described by the title, ensuring it is audit-friendly and fully tested.

Requirements and context

  • Must be secure, tested, and documented.
  • Keep changes minimal and reviewer-friendly.

Suggested execution

  • Fork the repo and create a branch: git checkout -b fix/vault-withdraw-event-shape
  • Implement changes in the Callora-Contracts Soroban workspace (contracts/*/src/).
  • Run cargo fmt, cargo clippy --all-targets --all-features -- -D warnings, and cargo test from the workspace root.
  • For WASM release builds: cargo build --target wasm32-unknown-unknown --release -p callora-vault (adjust -p if the crate name differs).

Deliverables

  • Update relevant lib.rs and test.rs.
  • Update docs where applicable (README.md, EVENT_SCHEMA.md, SECURITY.md).

Test and commit

  • Run tests and ./scripts/coverage.sh (or cargo tarpaulin per tarpaulin.toml).
  • Cover edge cases; include summarized test output and brief security notes in the PR description.

Example commit message

chore(contracts): emit `withdraw`/`withdraw_to` events with documented payload shape

Guidelines

  • Minimum 95% line coverage for touched crates (workspace policy).
  • Clear documentation (Rust /// on public items where applicable; repo markdown as needed).
  • Timeframe: 96 hours from assignment unless agreed otherwise.

Metadata

Metadata

Assignees

Type

No fields configured for Task.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions