Accessibility icons

mik-laj · mik-laj · commit 8a91dd8b6b56 · 2016-07-26T18:11:09.000+02:00
diff --git a/src/View/Helper/BootstrapHtmlHelper.php b/src/View/Helper/BootstrapHtmlHelper.php
@@ -86,6 +86,7 @@ public function icon ($icon, $options = []) {
     public function faIcon ($icon, $options = []) {
         $options = $this->addClass($options, 'fa');
         $options = $this->addClass($options, 'fa-'.$icon);
+        $options['aria-hidden'] = 'true';
 
         return $this->tag('i', '', $options);
     }
@@ -98,6 +99,7 @@ public function faIcon ($icon, $options = []) {
     public function glIcon ($icon, $options = []) {
         $options = $this->addClass($options, 'glyphicon');
         $options = $this->addClass($options, 'glyphicon-'.$icon);
+        $options['aria-hidden'] = 'true';
 
         return $this->tag('i', '', $options);
     }

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ public function icon ($icon, $options = []) {`
`86`	`86`	`public function faIcon ($icon, $options = []) {`
`87`	`87`	`$options = $this->addClass($options, 'fa');`
`88`	`88`	`$options = $this->addClass($options, 'fa-'.$icon);`
	`89`	`+ $options['aria-hidden'] = 'true';`
`89`	`90`
`90`	`91`	`return $this->tag('i', '', $options);`
`91`	`92`	`}`
`@@ -98,6 +99,7 @@ public function faIcon ($icon, $options = []) {`
`98`	`99`	`public function glIcon ($icon, $options = []) {`
`99`	`100`	`$options = $this->addClass($options, 'glyphicon');`
`100`	`101`	`$options = $this->addClass($options, 'glyphicon-'.$icon);`
	`102`	`+ $options['aria-hidden'] = 'true';`
`101`	`103`
`102`	`104`	`return $this->tag('i', '', $options);`
`103`	`105`	`}`