Skip to content

Fix Cake 5 SelectQuery type-hint in OneTimeLoginLinkBehavior #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steinkel merged 1 commit into from
May 7, 2026
+8 −8
Merged

Fix Cake 5 SelectQuery type-hint in OneTimeLoginLinkBehavior #1180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/Model/Behavior/OneTimeLoginLinkBehavior.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Cake\Datasource\Exception\RecordNotFoundException;
use Cake\I18n\DateTime;
use Cake\ORM\Behavior;
use Cake\ORM\Query;
use Cake\ORM\Query\SelectQuery;
use OutOfBoundsException;

/**
Expand Down Expand Up @@ -103,11 +103,11 @@ public function requestTokenSend(string $username): void
/**
* Find by username or email.
*
* @param \Cake\ORM\Query $query The query builder.
* @param \Cake\ORM\Query\SelectQuery $query The query builder.
* @param string|null $username Username or email.
* @return \Cake\ORM\Query
* @return \Cake\ORM\Query\SelectQuery
*/
public function findByUsernameOrEmail(Query $query, ?string $username = null): Query
public function findByUsernameOrEmail(SelectQuery $query, ?string $username = null): SelectQuery
{
if (empty($username)) {
throw new OutOfBoundsException('Missing username');
Expand All @@ -124,11 +124,11 @@ public function findByUsernameOrEmail(Query $query, ?string $username = null): Q
/**
* Find by token
*
* @param \Cake\ORM\Query $query
* @param string|null $token
* @return \Cake\ORM\Query
* @param \Cake\ORM\Query\SelectQuery $query The query builder.
* @param string|null $token Login token.
* @return \Cake\ORM\Query\SelectQuery
*/
public function findByOneTimeToken(Query $query, ?string $token = null): Query
public function findByOneTimeToken(SelectQuery $query, ?string $token = null): SelectQuery
{
if (empty($token)) {
throw new OutOfBoundsException('Missing token');
Expand Down
Loading