Skip to content
This repository was archived by the owner on May 13, 2026. It is now read-only.

Fix tool detection when unclosed backtick precedes tool call#480

Merged
CJackHwang merged 5 commits into
mainfrom
dev
May 10, 2026
Merged

Fix tool detection when unclosed backtick precedes tool call#480
CJackHwang merged 5 commits into
mainfrom
dev

Conversation

@CJackHwang
Copy link
Copy Markdown
Owner

Summary

  • Fixes issue where XML tool tags were ignored when preceded by an unclosed backtick in markdown inline code.
  • Updates the tool sieve to properly detect tool calls after stray backticks.
  • Resets markdown code span state appropriately at stream boundaries to ensure tool detection works.

Test plan

  • Added unit tests in fence_edge_sieve_test.go for unclosed inline markdown before tool calls.
  • Added JS tests in stream-tool-sieve.test.js for same-chunk and cross-chunk scenarios.
  • Verified existing tests still pass.

🤖 Generated with Claude Code

CJackHwang and others added 5 commits May 10, 2026 17:01
…HSA-rf34-c5jc-4ffw

[codex] fix security advisory and toolcall parsing issues
Handles cases where a stray backtick opens an inline code span but is never closed.
Previously, any subsequent XML tool tag was treated as inside markdown code and ignored.
Now, tool tags are detected after an unclosed backtick, and the markdown state is reset
when the backtick is confirmed to be literal text at stream boundaries.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ds2api Ready Ready Preview, Comment May 10, 2026 10:43am

@CJackHwang CJackHwang merged commit 4f0210f into main May 10, 2026
14 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77a47ada4e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/webui/handler.go
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant