Skip to content

Empty 'output_dir/matches.json' causing errors #18

@romainw

Description

@romainw

It seems 'output_dir/matches.json' does not exist at least when creating a new instance, which is causing errors:

dnscollector_1  | Exception in thread Thread-8 (daemonized_correlate):
dnscollector_1  | Traceback (most recent call last):
dnscollector_1  |   File "/usr/local/lib/python3.11/threading.py", line 1045, in _bootstrap_inner
dnscollector_1  |     self.run()
dnscollector_1  |   File "/usr/local/lib/python3.11/threading.py", line 982, in run
dnscollector_1  |     self._target(*self._args, **self._kwargs)
dnscollector_1  |   File "/usr/local/lib/python3.11/site-packages/pdnssoccli/subcommands/daemonize.py", line 34, in daemonized_correlate
dnscollector_1  |     ctx.invoke(correlate)
dnscollector_1  |   File "/usr/local/lib/python3.11/site-packages/click/core.py", line 783, in invoke
dnscollector_1  |     return __callback(*args, **kwargs)
dnscollector_1  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
dnscollector_1  |   File "/usr/local/lib/python3.11/site-packages/click/decorators.py", line 33, in new_func
dnscollector_1  |     return f(get_current_context(), *args, **kwargs)
dnscollector_1  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
dnscollector_1  |   File "/usr/local/lib/python3.11/site-packages/pdnssoccli/subcommands/correlate.py", line 289, in correlate
dnscollector_1  |     with jsonlines.open(Path(correlation_config['output_dir'], "matches.json"), mode='a') as writer:
dnscollector_1  |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
dnscollector_1  |   File "/usr/local/lib/python3.11/site-packages/jsonlines/jsonlines.py", line 643, in open
dnscollector_1  |     fp = builtins.open(file, mode=mode + "t", encoding=encoding)

Maybe this file should be created, even empty, during installation?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions