From 9213aa0b36306abb99bf3ecae8be8470a3d406ba Mon Sep 17 00:00:00 2001 From: Lachlan Whyborn Date: Tue, 24 Feb 2026 10:29:29 +1100 Subject: [PATCH 1/3] Try changing snowmelt declaration --- src/science/soilsnow/cbl_snowMelt.F90 | 5 +++-- src/science/soilsnow/cbl_thermal.F90 | 4 +--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/science/soilsnow/cbl_snowMelt.F90 b/src/science/soilsnow/cbl_snowMelt.F90 index 12ac79caa..843052470 100644 --- a/src/science/soilsnow/cbl_snowMelt.F90 +++ b/src/science/soilsnow/cbl_snowMelt.F90 @@ -1,6 +1,7 @@ MODULE snow_melting_mod USE cbl_ssnow_data_mod +USE cable_common_module PUBLIC snow_melting @@ -8,12 +9,11 @@ MODULE snow_melting_mod SUBROUTINE snow_melting (dels, snowmlt, ssnow, soil ) - USE cable_common_module IMPLICIT NONE REAL, INTENT(IN) :: dels ! integration time step (s) - REAL, DIMENSION(mp), INTENT(OUT) :: snowmlt ! snow melt + REAL, DIMENSION(:), INTENT(OUT) :: snowmlt ! snow melt TYPE(soil_parameter_type), INTENT(INOUT) :: soil TYPE(soil_snow_type), INTENT(INOUT) :: ssnow ! soil+snow variables @@ -27,6 +27,7 @@ SUBROUTINE snow_melting (dels, snowmlt, ssnow, soil ) REAL, DIMENSION(mp,0:3) :: smelt1 + ALLOCATE(ssnow(SIZE(ssnow%smelt))) snowmlt= 0.0 smelt1 = 0.0 diff --git a/src/science/soilsnow/cbl_thermal.F90 b/src/science/soilsnow/cbl_thermal.F90 index cb682df1f..07ea0ea7e 100644 --- a/src/science/soilsnow/cbl_thermal.F90 +++ b/src/science/soilsnow/cbl_thermal.F90 @@ -28,12 +28,10 @@ SUBROUTINE snow_processes_soil_thermal(dels,ssnow,soil,veg,canopy,met,bal) TYPE(veg_parameter_type), INTENT(INOUT) :: veg TYPE(met_type), INTENT(INOUT) :: met ! all met forcing TYPE (balances_type), INTENT(INOUT) :: bal - REAL, DIMENSION(mp) :: snowmlt !track snow melt + REAL, DIMENSION(:), ALLOCATABLE :: snowmlt !track snow melt ! REAL, DIMENSION(:), INTENT(INOUT) :: snowmlt ! replaced by rk4417 - phase2 INTEGER :: k,i - snowmlt = 0.0 ! inserted by rk4417 - phase2 - CALL snowcheck (dels, ssnow, soil, met ) CALL snowdensity (dels, ssnow, soil) From 62f2bdb14aeaa3b9052a461ea1aa2988b2562c64 Mon Sep 17 00:00:00 2001 From: Lachlan Whyborn Date: Tue, 24 Feb 2026 10:50:11 +1100 Subject: [PATCH 2/3] Used wrong var in allocate call --- src/science/soilsnow/cbl_snowMelt.F90 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/science/soilsnow/cbl_snowMelt.F90 b/src/science/soilsnow/cbl_snowMelt.F90 index 843052470..e97e68171 100644 --- a/src/science/soilsnow/cbl_snowMelt.F90 +++ b/src/science/soilsnow/cbl_snowMelt.F90 @@ -27,7 +27,7 @@ SUBROUTINE snow_melting (dels, snowmlt, ssnow, soil ) REAL, DIMENSION(mp,0:3) :: smelt1 - ALLOCATE(ssnow(SIZE(ssnow%smelt))) + ALLOCATE(snowmlt(SIZE(ssnow%smelt))) snowmlt= 0.0 smelt1 = 0.0 From fad68802377080f15858e3635f8b51323883b38d Mon Sep 17 00:00:00 2001 From: Lachlan Whyborn Date: Tue, 24 Feb 2026 10:57:12 +1100 Subject: [PATCH 3/3] Add allocatable attribute --- src/science/soilsnow/cbl_snowMelt.F90 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/science/soilsnow/cbl_snowMelt.F90 b/src/science/soilsnow/cbl_snowMelt.F90 index e97e68171..03f13dd64 100644 --- a/src/science/soilsnow/cbl_snowMelt.F90 +++ b/src/science/soilsnow/cbl_snowMelt.F90 @@ -13,7 +13,7 @@ SUBROUTINE snow_melting (dels, snowmlt, ssnow, soil ) REAL, INTENT(IN) :: dels ! integration time step (s) - REAL, DIMENSION(:), INTENT(OUT) :: snowmlt ! snow melt + REAL, DIMENSION(:), ALLOCATABLE, INTENT(OUT) :: snowmlt ! snow melt TYPE(soil_parameter_type), INTENT(INOUT) :: soil TYPE(soil_snow_type), INTENT(INOUT) :: ssnow ! soil+snow variables