-
-
Notifications
You must be signed in to change notification settings - Fork 78
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Description
Both TpagerKeyboard and CardputerKeyboard (Adv) currently call xQueueSend with a 50ms timeout but do not check the return value. If the queue is full and the timeout expires, keypresses will be silently dropped, leading to a poor user experience during rapid typing.
Affected Files
Boards/LilygoTLoraPager/Source/devices/TpagerKeyboard.cpp(line 93)Boards/M5stackCardputerAdv/Source/devices/CardputerKeyboard.cpp
Expected Behavior
The code should check the return value of xQueueSend and handle failures appropriately (e.g., log a warning when keypresses are dropped).
References
- PR: Cardputer adv and more #395
- Comment: Cardputer adv and more #395 (comment)
- Requested by: @KenVanHoeylandt
d49406
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request