-
-
Notifications
You must be signed in to change notification settings - Fork 77
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Description
Some refactoring improvements for CardputerKeyboard.cpp were identified during code review but deferred for future work.
Remaining Items
The following items from the code review should be addressed:
Convert static local state to instance members: The processKeyboard() method uses static local booleans (shift_pressed, sym_pressed, cap_toggle, cap_toggle_armed) which should be converted to instance member variables in the CardputerKeyboard class. This ensures state is properly tied to the object instance.
Context
- Original PR: Cardputer adv and more #395
- Code review comment: Cardputer adv and more #395 (comment)
- File:
Boards/M5stackCardputerAdv/Source/devices/CardputerKeyboard.cpp - Requested by: @KenVanHoeylandt
Note
Most suggestions from the review were already applied. This issue tracks the remaining items for future implementation.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request