use GetFirstChildElement when need_count = false

Author: Bush2021

src/uia.cc

@@ -304,6 +304,7 @@ std::optional<TabContainer> FindTabContainer(
 
 }  // namespace
 
+// TODO: make it shorter
 std::optional<TabHitResult> FindTabHitResult(POINT pt,
                                              bool need_count,
                                              bool need_close_button) {
@@ -317,6 +318,55 @@ std::optional<TabHitResult> FindTabHitResult(POINT pt,
     return std::nullopt;
   }
 
+  auto build_result = [&](const ComPtr<IUIAutomationElement>& tab_element,
+                          int tab_count) {
+    TabHitResult result;
+    result.tab = tab_element;
+    result.tab_count = tab_count;
+
+    if (need_close_button) {
+      const auto close_btn = FindFirstInSubtree(
+          tab_element, CreateClassCondition(automation, L"TabCloseButton"));
+      if (close_btn) {
+        RECT close_rect;
+        if (SUCCEEDED(close_btn->get_CurrentBoundingRectangle(&close_rect))) {
+          result.on_close_button = PtInRect(&close_rect, pt) != FALSE;
+        }
+      }
+    }
+    return result;
+  };
+
+  if (!need_count) {
+    ComPtr<IUIAutomationTreeWalker> walker;
+    if (FAILED(automation->get_ControlViewWalker(&walker)) || !walker) {
+      return std::nullopt;
+    }
+
+    ComPtr<IUIAutomationElement> child;
+    if (FAILED(walker->GetFirstChildElement(tab_container->container.Get(),
+                                            child.ReleaseAndGetAddressOf()))) {
+      return std::nullopt;
+    }
+    while (child) {
+      if (IsClassName(child, tab_container->tab_class)) {
+        RECT rect;
+        if (SUCCEEDED(child->get_CurrentBoundingRectangle(&rect)) &&
+            PtInRect(&rect, pt)) {
+          return build_result(child, 0);
+        }
+      }
+
+      ComPtr<IUIAutomationElement> next;
+      if (FAILED(walker->GetNextSiblingElement(
+              child.Get(), next.ReleaseAndGetAddressOf()))) {
+        break;
+      }
+      child = std::move(next);
+    }
+    return std::nullopt;
+  }
+
   const auto condition =
       CreateClassCondition(automation, tab_container->tab_class);
   ComPtr<IUIAutomationElementArray> arr;
@@ -344,22 +394,7 @@ std::optional<TabHitResult> FindTabHitResult(POINT pt,
       continue;
     }
 
-    TabHitResult result;
-    result.tab = tab_element;
-    result.tab_count = need_count ? count : 0;
-
-    if (need_close_button) {
-      const auto close_btn = FindFirstInSubtree(
-          tab_element, CreateClassCondition(automation, L"TabCloseButton"));
-      if (close_btn) {
-        RECT close_rect;
-        if (SUCCEEDED(close_btn->get_CurrentBoundingRectangle(&close_rect))) {
-          result.on_close_button = PtInRect(&close_rect, pt) != FALSE;
-        }
-      }
-    }
-
-    return result;
+    return build_result(tab_element, count);
   }
 
   return std::nullopt;