WIP IsOnCloseButton

Author: Bush2021

src/tabbookmark.cc

@@ -140,7 +140,7 @@ bool HandleDoubleClick(const MOUSEHOOKSTRUCT* pmouse) {
     return false;
   }
   // Avoid triggering on close button clicks.
-  if (IsOnCloseButton(tab, pt)) {
+  if (IsOnCloseButton(pt)) {
     return false;
   }
   if (tab_count == 1) {
@@ -221,7 +221,7 @@ bool HandleCloseButton(const MOUSEHOOKSTRUCT* pmouse) {
   // Get the tab under mouse and check if close button is clicked within it.
   // This prevents false positives from other PUSHBUTTON elements like
   // New Tab Button.
-  if (!tab || !IsOnCloseButton(tab, pt)) {
+  if (!tab || !IsOnCloseButton(pt)) {
     return false;
   }
   if (!IsNeedKeep(tab_count, KeepTabTrigger::kCloseButton)) {

src/uia.cc

@@ -113,26 +113,26 @@ bool TryGetCurrentStringProperty(const ComPtr<IUIAutomationElement>& element,
   return true;
 }
 
-bool FindFirstInSubtree(
-    const ComPtr<IUIAutomationElement>& root,
-    const ComPtr<IUIAutomationCondition>& condition,
-    const ComPtr<IUIAutomationCacheRequest>& cache_request) {
-  if (!root || !condition) {
-    return false;
-  }
-
-  ComPtr<IUIAutomationElement> hit;
-  if (SUCCEEDED(root->FindFirstBuildCache(TreeScope_Subtree, condition.Get(),
-                                          cache_request.Get(), &hit)) &&
-      hit != nullptr) {
-    return true;
+ComPtr<IUIAutomationCondition> MakeClassCondition(
+    const ComPtr<IUIAutomation>& automation,
+    std::wstring_view class_name) {
+  ScopedVariant val;
+  val.value.vt = VT_BSTR;
+  val.value.bstrVal = SysAllocStringLen(class_name.data(),
+                                        static_cast<UINT>(class_name.size()));
+  if (!val.value.bstrVal) {
+    return nullptr;
   }
 
-  hit.Reset();
-  if (FAILED(root->FindFirst(TreeScope_Subtree, condition.Get(), &hit))) {
-    return false;
+  ComPtr<IUIAutomationCondition> condition;
+  if (FAILED(automation->CreatePropertyCondition(
+          UIA_ClassNamePropertyId, val.value,
+          condition.ReleaseAndGetAddressOf()))) {
+    {
+      return nullptr;
+    }
   }
-  return hit != nullptr;
+  return condition;
 }
 
 bool IsClassName(const ComPtr<IUIAutomationElement>& element,
@@ -152,8 +152,91 @@ bool IsClassName(const ComPtr<IUIAutomationElement>& element,
   return is_match;
 }
 
+ComPtr<IUIAutomationElement> FindFirstInSubtree(
+    const ComPtr<IUIAutomationElement>& root,
+    const ComPtr<IUIAutomationCondition>& condition) {
+  if (!root || !condition) {
+    return nullptr;
+  }
+
+  // TODO: consider caching
+  ComPtr<IUIAutomationElement> hit;
+  if (FAILED(root->FindFirst(TreeScope_Subtree, condition.Get(),
+                             hit.ReleaseAndGetAddressOf()))) {
+    return nullptr;
+  }
+  return hit;
+}
+
+bool FindSiblingByClass(const ComPtr<IUIAutomation>& automation,
+                        const ComPtr<IUIAutomationElement>& element,
+                        std::wstring_view class_name,
+                        ComPtr<IUIAutomationElement>* out) {
+  ComPtr<IUIAutomationTreeWalker> walker;
+  if (FAILED(automation->get_ControlViewWalker(&walker)) || !walker) {
+    return false;
+  }
+
+  for (bool forward : {true, false}) {
+    ComPtr<IUIAutomationElement> current;
+    HRESULT hr = forward ? walker->GetNextSiblingElement(
+                               element.Get(), current.ReleaseAndGetAddressOf())
+                         : walker->GetPreviousSiblingElement(
+                               element.Get(), current.ReleaseAndGetAddressOf());
+    while (SUCCEEDED(hr) && current) {
+      if (IsClassName(current, class_name)) {
+        *out = std::move(current);
+        return true;
+      }
+      ComPtr<IUIAutomationElement> next;
+      hr = forward ? walker->GetNextSiblingElement(
+                         current.Get(), next.ReleaseAndGetAddressOf())
+                   : walker->GetPreviousSiblingElement(
+                         current.Get(), next.ReleaseAndGetAddressOf());
+      current = std::move(next);
+    }
+  }
+  return false;
+}
+
 }  // namespace
 
+bool IsOnCloseButton(POINT pt) {
+  if (!EnsureAutomation()) {
+    return false;
+  }
+  const auto& automation = GetUiaThreadState().automation;
+
+  ComPtr<IUIAutomationElement> pointed;
+  if (!TryGetElementFromPoint(automation, pt, &pointed)) {
+    return false;
+  }
+
+  ComPtr<IUIAutomationElement> root;
+  if (IsClassName(pointed, L"ScrollView")) {
+    // vertical tabs
+    root = pointed;
+  } else if (IsClassName(pointed, L"TabStrip::TabDragContextImpl")) {
+    // horizontal tabs
+    if (!FindSiblingByClass(automation, pointed, L"TabContainerImpl", &root)) {
+      return false;
+    }
+  } else {
+    return false;
+  }
+
+  auto close_btn = FindFirstInSubtree(
+      root, MakeClassCondition(automation, L"TabCloseButton"));
+  if (!close_btn) {
+    return false;
+  }
+
+  RECT rect;
+  if (FAILED(close_btn->get_CurrentBoundingRectangle(&rect)))
+    return false;
+  return PtInRect(&rect, pt) != FALSE;
+}
+
 bool IsOnBookmark(POINT pt) {
   if (!EnsureAutomation()) {
     return false;

src/uia.h

@@ -3,6 +3,7 @@
 
 #include <windows.h>
 
+bool IsOnCloseButton(POINT pt);
 bool IsOnBookmark(POINT pt);
 bool IsOmniboxFocused();