add TODO

Author: Bush2021

src/tabbookmark.cc

@@ -221,7 +221,7 @@ bool HandleCloseButton(const MOUSEHOOKSTRUCT* pmouse) {
   // Get the tab under mouse and check if close button is clicked within it.
   // This prevents false positives from other PUSHBUTTON elements like
   // New Tab Button.
-  if (!tab || !IsOnCloseButton(pt)) {
+  if (!tab || !IsOnCloseButton(pt)) { // TODO: it seems buggy here
     return false;
   }
   if (!IsNeedKeep(tab_count, KeepTabTrigger::kCloseButton)) {

src/uia.cc

@@ -64,6 +64,8 @@ bool EnsureAutomation() {
   }
   return true;
 }
+
+// TODO: get rid of *out parameters
 bool TryGetFocusedElement(const ComPtr<IUIAutomation>& automation,
                           ComPtr<IUIAutomationElement>* focused) {
   if (!automation || !focused) {
@@ -74,6 +76,7 @@ bool TryGetFocusedElement(const ComPtr<IUIAutomation>& automation,
          focused->Get() != nullptr;
 }
 
+// TODO: get rid of *out parameters
 bool TryGetElementFromHandle(const ComPtr<IUIAutomation>& automation,
                              HWND hwnd,
                              ComPtr<IUIAutomationElement>* element) {
@@ -85,6 +88,7 @@ bool TryGetElementFromHandle(const ComPtr<IUIAutomation>& automation,
          element->Get() != nullptr;
 }
 
+// TODO: get rid of *out parameters
 bool TryGetElementFromPoint(const ComPtr<IUIAutomation>& automation,
                             POINT pt,
                             ComPtr<IUIAutomationElement>* element) {
@@ -96,6 +100,7 @@ bool TryGetElementFromPoint(const ComPtr<IUIAutomation>& automation,
          element->Get() != nullptr;
 }
 
+// TODO: get rid of *out parameters
 bool TryGetCurrentStringProperty(const ComPtr<IUIAutomationElement>& element,
                                  PROPERTYID property_id,
                                  std::wstring* value) {
@@ -116,6 +121,10 @@ bool TryGetCurrentStringProperty(const ComPtr<IUIAutomationElement>& element,
 ComPtr<IUIAutomationCondition> MakeClassCondition(
     const ComPtr<IUIAutomation>& automation,
     std::wstring_view class_name) {
+  if (!automation || class_name.empty()) {
+    return nullptr;
+  }
+
   ScopedVariant val;
   val.value.vt = VT_BSTR;
   val.value.bstrVal = SysAllocStringLen(class_name.data(),
@@ -128,9 +137,7 @@ ComPtr<IUIAutomationCondition> MakeClassCondition(
   if (FAILED(automation->CreatePropertyCondition(
           UIA_ClassNamePropertyId, val.value,
           condition.ReleaseAndGetAddressOf()))) {
-    {
-      return nullptr;
-    }
+    return nullptr;
   }
   return condition;
 }
@@ -168,6 +175,7 @@ ComPtr<IUIAutomationElement> FindFirstInSubtree(
   return hit;
 }
 
+// TODO: get rid of *out parameters
 bool FindSiblingByClass(const ComPtr<IUIAutomation>& automation,
                         const ComPtr<IUIAutomationElement>& element,
                         std::wstring_view class_name,