Skip to content

Commit a3ae5e3

Browse files
authored
Merge pull request #239 from maxnus/pr-pys2clientprotocol
Migrating from s2clientprotocol to pys2clientprotocol
2 parents d0596ce + c106d34 commit a3ae5e3

File tree

3 files changed

+58
-34
lines changed

3 files changed

+58
-34
lines changed

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ dependencies = [
3535
"numpy>=2.1.0; python_full_version >= '3.13'",
3636
"numpy>=2.0.0; python_full_version < '3.13'",
3737
"portpicker>=1.6.0",
38-
"protobuf<4.0.0",
39-
"s2clientprotocol>=5.0.14.93333.0",
38+
"pys2clientprotocol>=1.0.2",
4039
"scipy>=1.16.3; python_full_version >= '3.14'",
4140
"scipy>=1.14.1; python_full_version >= '3.13'",
4241
"scipy>=1.7.1; python_full_version < '3.13'",
@@ -51,6 +50,7 @@ dev = [
5150
"pillow>=12.0.0; python_full_version >= '3.14'",
5251
"pillow>=11.0.0; python_full_version < '3.14'",
5352
"pre-commit>=4.0.1",
53+
"protobuf>=6,<8",
5454
"pyglet>=2.0.20",
5555
"pylint>=3.3.2",
5656
# Type checker

test/test_pickled_data.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import math
1515
import pickle
1616
import random
17-
import sys
1817
import unittest
1918
from contextlib import suppress
2019
from pathlib import Path
@@ -72,10 +71,8 @@ def get_map_specific_bot(map_path: Path) -> BotAI:
7271

7372

7473
def test_protobuf_implementation():
75-
"""Make sure that cpp is used as implementation"""
76-
# Doesn't seem to be implemented in newer python versions
77-
if sys.version_info < (3, 10) and sys.platform != "darwin":
78-
assert api_implementation.Type() == "cpp"
74+
"""Make sure that upb is used as implementation"""
75+
assert api_implementation.Type() == "upb"
7976

8077

8178
def test_bot_ai():

uv.lock

Lines changed: 54 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)