COVERITY RESOURCE_LEAK - Missing parse_arg_eq_done() before return

[shao-liancheng]

OpenBCM/sdk-6.5.21/src/appl/test/randaddr.c

Line 385 in 954b242

return 1;

'parse_arg_eq_done(&pt)' should be called to free memory before function return. Please go over all the 'return' in this function.

There are multiple instance return the function without calling parse_arg_eq_done().

The right behavior should be 3 steps
test_error("xxxxxx", ...); // print proper error information.
rv = xx; // set proper error value
goto done; // go to the function end to release memory.

for example:

OpenBCM/sdk-6.5.21/src/appl/test/randaddr.c

Lines 594 to 598 in 954b242

	rv = soc_mem_clear(unit, EXT_ACL432_TCAM_MASKm,
	MEM_BLOCK_ALL, TRUE);
	if (rv < 0) {
	test_error(unit, "Could not clear EXT_ACL432_TCAM_MASK\n");
	goto done;