future linting error with golangci-lint revive

[ccoVeille]

Latest golangci-lint version would bring this linting error

cmd/validator/validator.go:143:2: deep-exit: calls to flag.Parse only in main() or init() functions (revive)
	flag.Parse()

There are two solutions here

• ignore it with a //nolint
• refactor the code to use flag.NewFlagSet (see deep-exit: improve error message for flag.Parse mgechev/revive#1612 )

What would be your call here @kehoecj ?

[charity254]

@ccoVeille I'd love to take a look at this if it is still available

[ccoVeille]

Please do @charity254

[charity254]

Great, since I will be working on this, could you please assign this issue to me so I can start on it?
@ccoVeille

[ccoVeille]

I'm not a member, so I cannot assign it to you. But you can work on it.

[kehoecj]

@charity254 I assigned it to you. Thanks for working it! Are you planning to refactor the code to use flag.NewFlagSet?

[charity254]

@kehoecj Thank you for assigning it. I am leaning toward refactoring to use flag.NewFlagSet so we avoid suppressing the lint warning and keep the code aligned with the linter expectations. Please let me know if you would prefer the nolint approach instead.

[kehoecj]

@charity254 Approach sounds good!