fix

Author: BobTheBuidler

faster_web3/_utils/events.py

@@ -178,8 +178,7 @@ def construct_event_data_set(
 
     normalized_args = {
         key: value if is_list_like(value) else [value]
-        # type ignored b/c at this point arguments is always a dict
-        for key, value in arguments.items()  # type: ignore
+        for key, value in arguments.items()
     }
 
     non_indexed_args = exclude_indexed_event_inputs(event_abi)
@@ -497,7 +496,7 @@ def _build_argument_filters_from_event_abi(
 array_to_tuple: Final = apply_formatter_if(is_list_like, tuple)
 
 
-def _normalize_match_values(match_values: Collection[Any]) -> Iterable[Any]:
+def _normalize_match_values(match_values: Collection[Any]) -> Tuple[Any, ...]:
     return tuple(map(array_to_tuple, match_values))
 
 
@@ -535,7 +534,6 @@ def match_values(self) -> None:
 
 @final
 class DataArgumentFilter(BaseArgumentFilter):
-    # type ignore b/c conflict with BaseArgumentFilter.match_values type
     @property
     def match_values(self) -> Union[
         Tuple[TypeStr, Tuple[Any, ...]],
@@ -550,12 +548,11 @@ def __init__(self, arg_type: TypeStr, abi_codec: ABICodec) -> None:
         super().__init__(arg_type)
         self.abi_codec: Final = abi_codec
 
-    def _get_match_values(self) -> Iterable[HexStr]:
+    def _get_match_values(self) -> Tuple[HexStr, ...]:
         return tuple(map(self._encode, cast(Tuple[Any, ...], self._match_values)))
 
-    # type ignore b/c conflict with BaseArgumentFilter.match_values type
     @property
-    def match_values(self) -> Optional[Tuple[HexStr, ...]]:  # type: ignore
+    def match_values(self) -> Optional[Tuple[HexStr, ...]]:
         return self._get_match_values() if self._match_values is not None else None
 
     def _encode(self, value: Any) -> HexStr:

tests/core/filtering/test_basic_filter_tests.py

@@ -9,7 +9,12 @@ def test_filtering_sequential_blocks_with_bounded_range(
 
     initial_block_number = w3.eth.block_number
 
-    builder.toBlock = initial_block_number + 100
+    # this line doesn't actually do anything but we had to change it because
+    # you can't assign a non-existent attribute to a compiled class.
+    # I'm not sure what the original intent was but the test passes with or
+    # without it.
+    builder.to_block = initial_block_number + 100
+
     filter_ = builder.deploy(w3)
     for _ in range(100):
         emitter.functions.logNoArgs(which=1).transact()
@@ -45,7 +50,13 @@ async def test_async_filtering_sequential_blocks_with_bounded_range(
     builder = async_emitter.events.LogNoArguments.build_filter()
     builder.from_block = "latest"
     initial_block_number = await async_w3.eth.block_number
-    builder.toBlock = initial_block_number + 100
+
+    # this line doesn't actually do anything but we had to change it because
+    # you can't assign a non-existent attribute to a compiled class.
+    # I'm not sure what the original intent was but the test passes with or
+    # without it.
+    builder.to_block = initial_block_number + 100
+    
     filter_ = await builder.deploy(async_w3)
     for _ in range(100):
         await async_emitter.functions.logNoArgs(which=1).transact()