Merge pull request #7621 from BitGo/BTC-2824.fix-default-consensus-branch-id-for-v4

fix(utxo-lib): fix default consensus branch id for v4/v5 transactions

Author: OttoAllmendinger

modules/abstract-utxo/test/unit/fixtures/zec/recovery/backupKeyRecovery-fullSignedRecovery-customUserKeyPath-p2sh.json

@@ -1,30 +1,30 @@
 {
   "inputs": [
     {
-      "id": "66f3f676804cd3a1fcc6186b5db9b926259e1dd21edd3dd19d6e672aeac88413:0",
+      "id": "cc7efd95b6f94acbda360651c780ea58c4c371037091109771afdcfaf33f335e:0",
       "address": "t3VimfbSM11ty24L5CUeA2DcSGkJvtep6pe",
       "value": 100000000,
       "chain": 1,
       "index": 0,
       "valueString": "100000000"
     },
     {
-      "id": "7955ab40f1d175d64f95ba5e7b62c133a909d2f89fc1ebf191826d76b7134c08:0",
+      "id": "cad6f281148a560b59d9a3a33e19dc7a83b92b1d322a325ff5bce018a5e2a1f3:0",
       "address": "t3VimfbSM11ty24L5CUeA2DcSGkJvtep6pe",
       "value": 200000000,
       "chain": 1,
       "index": 0,
       "valueString": "200000000"
     },
     {
-      "id": "24635df14fd48385b524a8e65848bf863c6e5597cca293c964bb049abab650d2:0",
+      "id": "6322784021da8096c91217a82799ffa18befe56f068f159e4179b4500c02465e:0",
       "address": "t3VimfbSM11ty24L5CUeA2DcSGkJvtep6pe",
       "value": 300000000,
       "chain": 1,
       "index": 0,
       "valueString": "300000000"
     }
   ],
-  "transactionHex": "0400008085202f89031384c8ea2a676e9dd13ddd1ed21d9e2526b9b95d6b18c6fca1d34c8076f6f36600000000fdfd0000483045022100d3026a5c92036f471db1c54e9d7fa16b588f8b5777c2ea011cb151209c8dbbd902203e3b3f52275de5c70e4ed7eeeb403c6ddaf7dd17a0f17344342b56fc6929b2d70147304402205b69079421f472e6cee3e0a23abc8aed8f853f77d9524ec2171a8b9be2d97040022039716461861b19d74203c85e6e82ad73a76b96d252e6e214b9d7ab4b29e32f9d014c69522102587d7749d1ed2a3d3d300b969e68cbedb042ea19e3ee90c4131e2092f5e1181e21030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffff084c13b7766d8291f1ebc19ff8d209a933c1627b5eba954fd675d1f140ab557900000000fc0047304402203417e9608b58f7a087671be4b8097078f25edd196e5ef67067cd321df4ae415102204a143345f99fd955a1c13000763c67dc8d1a48011ac2c0eaa15552760c0067ff01473044022049b0a338eeb017909cdbc6a67e308183fbed3db89704fea52f3e5b7a4b9a057e02201adbc835cb2adef12aa9273802448d1947cb2542d9cc5523feed697b11b25532014c69522102587d7749d1ed2a3d3d300b969e68cbedb042ea19e3ee90c4131e2092f5e1181e21030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffffd250b6ba9a04bb64c993a2cc97556e3c86bf4858e6a824b58583d44ff15d632400000000fdfd000047304402202f587719aec108594cf2592a207ec29a14f63295171feea759f8ecb64e11c5a502207347335e3f83961ddc09dd0d1f90b2a4e81511e2c90f22671f59d1c1c6dca6cc01483045022100e021a0ea34da5fd3ad48d2e6d5edda31ecb0bff8d403819817ee7cc54c9497b70220009150c8768e91e727ae902b82efd04a0a709c6bef8979a5adc9c790f3da9839014c69522102587d7749d1ed2a3d3d300b969e68cbedb042ea19e3ee90c4131e2092f5e1181e21030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffff010c44c3230000000017a91439c65a0d0072a140694d6b13ec5f5f2437de99ff8700000000000000000000000000000000000000",
-  "txid": "50b45f8414e76269646f2a8027b8949aeae65c28b6c3eb1c7462bf36a9dfd9ba"
+  "transactionHex": "0400008085202f89035e333ff3fadcaf71971091700371c3c458ea80c7510636dacb4af9b695fd7ecc00000000fdfd00004730440220760c457f931a17b3a0115c694b722b1f31e5ab4c3682120a00b36f3060c99a89022018a84f3f43e03421be2661ccbe6bd09594b82ff0eb7a37214d8178a6c718930201483045022100d7a338efa2e216b9e2c5ec9c13af0f0b454a947335a7bb6821b311f732f58de802203cd52f884fa96ad405d5c182b4bee53b276cc2c237586adb385f376a22c3b44f014c69522102587d7749d1ed2a3d3d300b969e68cbedb042ea19e3ee90c4131e2092f5e1181e21030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aefffffffff3a1e2a518e0bcf55f322a321d2bb9837adc193ea3a3d9590b568a1481f2d6ca00000000fdfd000047304402204c557fd7b70c6ca0e5278304c91f9f4a424153657b9cb250f41f6a63deaed5580220049055799af4eac707f1b6240980e2ec4a42c34c64fb467f0e4c3c59e2015abb01483045022100e89bbfe5bc08d65146702138c46534c8b874e6bbc47e341342b4595ad69278ba02202262dcf6d5c2f70c01f5c22bc5bafb6e2236203b31aaa2049c703815e42d9e86014c69522102587d7749d1ed2a3d3d300b969e68cbedb042ea19e3ee90c4131e2092f5e1181e21030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffff5e46020c50b479419e158f066fe5ef8ba1ff9927a81712c99680da214078226300000000fdfd00004730440220478312370b1260d44e35fce771f2478b526b29e03ed6a4308b205edc5c635032022059c4c44949c150013f92e50ba7418db299ca003ef9e182fb9e5b1a309266a92b01483045022100fd07db3ce2febd3b2ded0d127a216d5dbaa229cc3af7c0ec2a4842b723f673d502203d2eacd64a86920049084f2eadbc712e45926c5bff563c7f96304cf083bebb3e014c69522102587d7749d1ed2a3d3d300b969e68cbedb042ea19e3ee90c4131e2092f5e1181e21030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffff010c44c3230000000017a91439c65a0d0072a140694d6b13ec5f5f2437de99ff8700000000000000000000000000000000000000",
+  "txid": "c2d6c47d5f11b34507eef54bb2efb61ee56e0648188b59f90da38b367b50999b"
 }

modules/abstract-utxo/test/unit/fixtures/zec/recovery/backupKeyRecovery-fullSignedRecovery-fixedFeeRate-p2sh.json

@@ -1,30 +1,30 @@
 {
   "inputs": [
     {
-      "id": "e3c1f3595baf0982710dc20783f451173b0d17c5ea0027236f83a474f82dae17:0",
+      "id": "9828c8f963402188c062badc31e9537cf9fb8f9733221e01281240ede7e31443:0",
       "address": "t3QhzMeyxZ1QybXD1yCLyMw7XwgwUjsvcvH",
       "value": 100000000,
       "chain": 1,
       "index": 0,
       "valueString": "100000000"
     },
     {
-      "id": "7f43b37c0b236a9f7525b19ddf655c849109439c31aa4f7963661cfd7a573bb7:0",
+      "id": "f104130b87b6330a55b55d0eea59e795cd678539708c5c4e752374e4a14b067e:0",
       "address": "t3QhzMeyxZ1QybXD1yCLyMw7XwgwUjsvcvH",
       "value": 200000000,
       "chain": 1,
       "index": 0,
       "valueString": "200000000"
     },
     {
-      "id": "7485951374e5fc76ede09d378ae03113d6becf44815db3face0a45b4cafb85c8:0",
+      "id": "8c7f853d025ccdca3264b7b0df5f92f544f1e72559cf457d20c2daa108ca0f26:0",
       "address": "t3QhzMeyxZ1QybXD1yCLyMw7XwgwUjsvcvH",
       "value": 300000000,
       "chain": 1,
       "index": 0,
       "valueString": "300000000"
     }
   ],
-  "transactionHex": "0400008085202f890317ae2df874a4836f232700eac5170d3b1751f48307c20d718209af5b59f3c1e300000000fdfd0000483045022100b90d97a9db971d3bd5a6ef5eb59c0aa35452c40a9589b8659d8466b8b32b9e0902205d1af348c278d29d71a40d4c8c96e8f930c19f51c0850f7a21f40a79882adfed01473044022063a15a1f6b3f619a6dd6683b4db6db1fe60a0bd7830ef9e8328a76c60bd3e67d0220478a5c68f4432ac088d73b62050841addf7e3c4b688b0d9703e2c79d74e3d480014c69522102d06c08ccf0fddefff881e869b951d4b92e936118b3360182c5b8c55f4c40bc6121030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffffb73b577afd1c6663794faa319c430991845c65df9db125759f6a230b7cb3437f00000000fdfd0000483045022100fee3c330829cfa7f9901bc99c166130ba17992c9cd93be37029741a18e504a63022072e3a05f0a60a2476e0eaa2f1fafa0b6071f7c7a9ee93e26c83376ea8584b6960147304402204c6377c202d0c55954e1fbad705f829ab08d8506e3d61837cee4cb4fb154bed902201b91c9601608bd6358c4219bea96ed0474c7a2c276e7cf7366b623433fd5e9d0014c69522102d06c08ccf0fddefff881e869b951d4b92e936118b3360182c5b8c55f4c40bc6121030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffffc885fbcab4450acefab35d8144cfbed61331e08a379de0ed76fce5741395857400000000fdfe0000483045022100afece795633ee46d1a0256e6be1b2f51a8c18f7c1c66d31aa9889c57449f320a022016162f2be1b0bc59222bafe8240467e5e9d8b8995e4a60634a206b68b54d7e2501483045022100e81d5568c6f1f9da8b62e2e5929822fb88093d9e7571446d475b9f9c07fbc88e02203480f2d968e1a651814b79eb05d8ce767960f0fdf195de581c4a15dcff150522014c69522102d06c08ccf0fddefff881e869b951d4b92e936118b3360182c5b8c55f4c40bc6121030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffff010c44c3230000000017a91439c65a0d0072a140694d6b13ec5f5f2437de99ff8700000000000000000000000000000000000000",
-  "txid": "848899b0134a1fa87077a42c118109c97ad208c66dc36d48cef72f74712300db"
+  "transactionHex": "0400008085202f89034314e3e7ed401228011e2233978ffbf97c53e931dcba62c088214063f9c8289800000000fc00473044022055229dad2cf548bdf650ec72859ef5fe3bd2b2b109b3c882ff6d0bb4235da241022018b0f963d5ccff41db7f134a4d8cc2f15ce8fe709060667317325f6c56712aba01473044022013afbcd2f4e0c5753618ac3c491cdf7e6a89f896cf54aa80ce28a9e6989c04d40220475e44316c18c053ab20633906c2e740a3e364a6ea12738a1025812a066097a2014c69522102d06c08ccf0fddefff881e869b951d4b92e936118b3360182c5b8c55f4c40bc6121030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffff7e064ba1e47423754e5c8c70398567cd95e759ea0e5db5550a33b6870b1304f100000000fdfd0000483045022100d3edd7c1071f55de6f415a6552aa74c2739593987101684b41de3b452684225902205a11c17db558e9c8f771ed0418ff3d842bc73e0fb3442db3f54f4aef08720baa014730440220066159a80705ff014470d1118bc622c9ffcb04da6eb6d962cf52ee741b5ee52f02203ce57ed62b032f58f921a83d6f0f200beee63761fe1fd1139f491ef7a5712bc2014c69522102d06c08ccf0fddefff881e869b951d4b92e936118b3360182c5b8c55f4c40bc6121030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffff260fca08a1dac2207d45cf5925e7f144f5925fdfb0b76432cacd5c023d857f8c00000000fdfd0000483045022100d84b89c822f27f016b23d2ef120934c192d0c049ebd75e9014a726d3fef801b002202e29c31c08b6268501a55678ffd5d36ea47ceaf60805f9845e1e10dd8d4ae9dc01473044022054e7c758700b72f4071f5c5f35a2fa53f48a5acc0d1f57c2a30c9c20781efa63022075918f03c124727813ecc6468675ed025fad006927b7144631e94bb4a076b695014c69522102d06c08ccf0fddefff881e869b951d4b92e936118b3360182c5b8c55f4c40bc6121030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffff010c44c3230000000017a91439c65a0d0072a140694d6b13ec5f5f2437de99ff8700000000000000000000000000000000000000",
+  "txid": "e4ae263fa2f935529058c1842c5ab06cea053e68730a6c17bb60558526338ae5"
 }

modules/abstract-utxo/test/unit/fixtures/zec/recovery/backupKeyRecovery-fullSignedRecovery-p2sh.json

@@ -1,30 +1,30 @@
 {
   "inputs": [
     {
-      "id": "e3c1f3595baf0982710dc20783f451173b0d17c5ea0027236f83a474f82dae17:0",
+      "id": "9828c8f963402188c062badc31e9537cf9fb8f9733221e01281240ede7e31443:0",
       "address": "t3QhzMeyxZ1QybXD1yCLyMw7XwgwUjsvcvH",
       "value": 100000000,
       "chain": 1,
       "index": 0,
       "valueString": "100000000"
     },
     {
-      "id": "7f43b37c0b236a9f7525b19ddf655c849109439c31aa4f7963661cfd7a573bb7:0",
+      "id": "f104130b87b6330a55b55d0eea59e795cd678539708c5c4e752374e4a14b067e:0",
       "address": "t3QhzMeyxZ1QybXD1yCLyMw7XwgwUjsvcvH",
       "value": 200000000,
       "chain": 1,
       "index": 0,
       "valueString": "200000000"
     },
     {
-      "id": "7485951374e5fc76ede09d378ae03113d6becf44815db3face0a45b4cafb85c8:0",
+      "id": "8c7f853d025ccdca3264b7b0df5f92f544f1e72559cf457d20c2daa108ca0f26:0",
       "address": "t3QhzMeyxZ1QybXD1yCLyMw7XwgwUjsvcvH",
       "value": 300000000,
       "chain": 1,
       "index": 0,
       "valueString": "300000000"
     }
   ],
-  "transactionHex": "0400008085202f890317ae2df874a4836f232700eac5170d3b1751f48307c20d718209af5b59f3c1e300000000fdfd0000483045022100b90d97a9db971d3bd5a6ef5eb59c0aa35452c40a9589b8659d8466b8b32b9e0902205d1af348c278d29d71a40d4c8c96e8f930c19f51c0850f7a21f40a79882adfed01473044022063a15a1f6b3f619a6dd6683b4db6db1fe60a0bd7830ef9e8328a76c60bd3e67d0220478a5c68f4432ac088d73b62050841addf7e3c4b688b0d9703e2c79d74e3d480014c69522102d06c08ccf0fddefff881e869b951d4b92e936118b3360182c5b8c55f4c40bc6121030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffffb73b577afd1c6663794faa319c430991845c65df9db125759f6a230b7cb3437f00000000fdfd0000483045022100fee3c330829cfa7f9901bc99c166130ba17992c9cd93be37029741a18e504a63022072e3a05f0a60a2476e0eaa2f1fafa0b6071f7c7a9ee93e26c83376ea8584b6960147304402204c6377c202d0c55954e1fbad705f829ab08d8506e3d61837cee4cb4fb154bed902201b91c9601608bd6358c4219bea96ed0474c7a2c276e7cf7366b623433fd5e9d0014c69522102d06c08ccf0fddefff881e869b951d4b92e936118b3360182c5b8c55f4c40bc6121030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffffc885fbcab4450acefab35d8144cfbed61331e08a379de0ed76fce5741395857400000000fdfe0000483045022100afece795633ee46d1a0256e6be1b2f51a8c18f7c1c66d31aa9889c57449f320a022016162f2be1b0bc59222bafe8240467e5e9d8b8995e4a60634a206b68b54d7e2501483045022100e81d5568c6f1f9da8b62e2e5929822fb88093d9e7571446d475b9f9c07fbc88e02203480f2d968e1a651814b79eb05d8ce767960f0fdf195de581c4a15dcff150522014c69522102d06c08ccf0fddefff881e869b951d4b92e936118b3360182c5b8c55f4c40bc6121030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffff010c44c3230000000017a91439c65a0d0072a140694d6b13ec5f5f2437de99ff8700000000000000000000000000000000000000",
-  "txid": "848899b0134a1fa87077a42c118109c97ad208c66dc36d48cef72f74712300db"
+  "transactionHex": "0400008085202f89034314e3e7ed401228011e2233978ffbf97c53e931dcba62c088214063f9c8289800000000fc00473044022055229dad2cf548bdf650ec72859ef5fe3bd2b2b109b3c882ff6d0bb4235da241022018b0f963d5ccff41db7f134a4d8cc2f15ce8fe709060667317325f6c56712aba01473044022013afbcd2f4e0c5753618ac3c491cdf7e6a89f896cf54aa80ce28a9e6989c04d40220475e44316c18c053ab20633906c2e740a3e364a6ea12738a1025812a066097a2014c69522102d06c08ccf0fddefff881e869b951d4b92e936118b3360182c5b8c55f4c40bc6121030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffff7e064ba1e47423754e5c8c70398567cd95e759ea0e5db5550a33b6870b1304f100000000fdfd0000483045022100d3edd7c1071f55de6f415a6552aa74c2739593987101684b41de3b452684225902205a11c17db558e9c8f771ed0418ff3d842bc73e0fb3442db3f54f4aef08720baa014730440220066159a80705ff014470d1118bc622c9ffcb04da6eb6d962cf52ee741b5ee52f02203ce57ed62b032f58f921a83d6f0f200beee63761fe1fd1139f491ef7a5712bc2014c69522102d06c08ccf0fddefff881e869b951d4b92e936118b3360182c5b8c55f4c40bc6121030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffff260fca08a1dac2207d45cf5925e7f144f5925fdfb0b76432cacd5c023d857f8c00000000fdfd0000483045022100d84b89c822f27f016b23d2ef120934c192d0c049ebd75e9014a726d3fef801b002202e29c31c08b6268501a55678ffd5d36ea47ceaf60805f9845e1e10dd8d4ae9dc01473044022054e7c758700b72f4071f5c5f35a2fa53f48a5acc0d1f57c2a30c9c20781efa63022075918f03c124727813ecc6468675ed025fad006927b7144631e94bb4a076b695014c69522102d06c08ccf0fddefff881e869b951d4b92e936118b3360182c5b8c55f4c40bc6121030795af84ecc10252d8a894f54845beeb5624a1c24c3747cc654bd430539dee3521029b30ebe8eb23f8cec82f25a80e3b423979ec3ba1fe07d9d4ed9f6361258bc31d53aeffffffff010c44c3230000000017a91439c65a0d0072a140694d6b13ec5f5f2437de99ff8700000000000000000000000000000000000000",
+  "txid": "e4ae263fa2f935529058c1842c5ab06cea053e68730a6c17bb60558526338ae5"
 }