From ac63a5fdc2b589e2d67d76684e6e0d13156b24c9 Mon Sep 17 00:00:00 2001 From: LiNk-NY Date: Fri, 31 Oct 2025 12:29:41 -0400 Subject: [PATCH 1/5] update package size requirement --- R/checks.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/R/checks.R b/R/checks.R index 5c9fd18..23b83a5 100644 --- a/R/checks.R +++ b/R/checks.R @@ -28,11 +28,11 @@ checkDeprecatedPackages <- function(.BiocPackage) } } -checkPackageSize <- function(.BiocPackage, size=5){ +checkPackageSize <- function(.BiocPackage, size=10){ pkg <- .BiocPackage$sourceDir pkgType <- .BiocPackage$packageType if (is.na(pkgType) || pkgType == "Software") { - maxSize <- size*10^6 ## 5MB + maxSize <- size*10^6 ## in MB pkgSize <- file.size(pkg) if (pkgSize > maxSize){ msgs <- c( From 80706129cd6863f465ccef08681beecffce8316c Mon Sep 17 00:00:00 2001 From: LiNk-NY Date: Fri, 31 Oct 2025 12:32:53 -0400 Subject: [PATCH 2/5] change size requirement in vignette --- vignettes/BiocCheck.Rmd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vignettes/BiocCheck.Rmd b/vignettes/BiocCheck.Rmd index a1b697e..5b6aa77 100644 --- a/vignettes/BiocCheck.Rmd +++ b/vignettes/BiocCheck.Rmd @@ -156,7 +156,7 @@ Can be disabled with `--no-check-pkg-size` and `--no-check-file-size`. * **Checking package size** Checks that the package size meets _Bioconductor_ requirements. The current - package size limit is 5 MB for Software packages. Experiment Data and + package size limit is 10 MB for Software packages. Experiment Data and Annotation packages are excluded from this check. This check is only run if checking a source tarball. (ERROR) From 20c1aa786bad7a4fb5eae510243f95394a17fe9b Mon Sep 17 00:00:00 2001 From: LiNk-NY Date: Tue, 4 Nov 2025 12:19:44 -0500 Subject: [PATCH 3/5] update NEWS --- NEWS | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/NEWS b/NEWS index 44ec7f0..57cd815 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,11 @@ +CHANGES IN VERSION 1.48.0 +----------------------- + +BUG FIXES AND MINOR IMPROVEMENTS + + o Package tarball size check updated to have a max of 10 MB (@LiNk-NY, + #234). + CHANGES IN VERSION 1.46.0 ----------------------- From c3abb9a66a35ec34c79578d896e06ffd5eeccecf Mon Sep 17 00:00:00 2001 From: LiNk-NY Date: Tue, 4 Nov 2025 13:35:27 -0500 Subject: [PATCH 4/5] use default package size in checkPackageSize call --- R/BiocCheck.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/BiocCheck.R b/R/BiocCheck.R index b231cfd..4c32430 100644 --- a/R/BiocCheck.R +++ b/R/BiocCheck.R @@ -205,7 +205,7 @@ BiocCheckRun <- if (is.null(dots[["no-check-pkg-size"]])){ handleCheck("Checking package size...") if (.BiocPackage$isTar){ - checkPackageSize(.BiocPackage, size=5) + checkPackageSize(.BiocPackage) } else { handleMessage("Skipped... only checked on source tarball", indent=4) } From 00d4e7825f21924e5f18a680469159168b268159 Mon Sep 17 00:00:00 2001 From: LiNk-NY Date: Tue, 4 Nov 2025 13:35:36 -0500 Subject: [PATCH 5/5] minor update spacing --- R/checks.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/R/checks.R b/R/checks.R index 23b83a5..2a3fa0b 100644 --- a/R/checks.R +++ b/R/checks.R @@ -28,13 +28,13 @@ checkDeprecatedPackages <- function(.BiocPackage) } } -checkPackageSize <- function(.BiocPackage, size=10){ +checkPackageSize <- function(.BiocPackage, size = 10) { pkg <- .BiocPackage$sourceDir pkgType <- .BiocPackage$packageType if (is.na(pkgType) || pkgType == "Software") { maxSize <- size*10^6 ## in MB pkgSize <- file.size(pkg) - if (pkgSize > maxSize){ + if (pkgSize > maxSize) { msgs <- c( paste0("Package Size: ", as.character(round(pkgSize/(10^6),2)), " MB"),