From 50b568c77c89bdf7142227d0d8fde61ab26aa604 Mon Sep 17 00:00:00 2001 From: SexyERIC0723 Date: Fri, 27 Mar 2026 20:09:00 +0000 Subject: [PATCH] fix: correct bernoulli_loader kwarg, remove duplicate import, fix mutable default - Fix bernoulli_loader reading 'dt' instead of 'max_prob' from kwargs in encoding/loaders.py. The docstring documents max_prob but the code was fetching the wrong key. - Remove duplicate 'import numpy as np' in network/monitors.py. - Fix mutable default argument pipeline=[] in MulticompartmentConnection.__init__. Changed to None with guard. --- bindsnet/encoding/loaders.py | 2 +- bindsnet/network/monitors.py | 4 ---- bindsnet/network/topology.py | 2 +- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/bindsnet/encoding/loaders.py b/bindsnet/encoding/loaders.py index 3ba7f881..eb194d1f 100644 --- a/bindsnet/encoding/loaders.py +++ b/bindsnet/encoding/loaders.py @@ -26,7 +26,7 @@ def bernoulli_loader( :param float max_prob: Maximum probability of spike per Bernoulli trial. """ # Setting kwargs. - max_prob = kwargs.get("dt", 1.0) + max_prob = kwargs.get("max_prob", 1.0) for i in range(len(data)): # Encode datum as Bernoulli spike trains. diff --git a/bindsnet/network/monitors.py b/bindsnet/network/monitors.py index 4446e678..4098a0c2 100644 --- a/bindsnet/network/monitors.py +++ b/bindsnet/network/monitors.py @@ -4,10 +4,6 @@ import numpy as np import torch -import numpy as np - -from abc import ABC -from typing import Union, Optional, Iterable, Dict from bindsnet.network.nodes import Nodes from bindsnet.network.topology import ( diff --git a/bindsnet/network/topology.py b/bindsnet/network/topology.py index 10df4582..00361ffa 100644 --- a/bindsnet/network/topology.py +++ b/bindsnet/network/topology.py @@ -410,7 +410,7 @@ def __init__( source: Nodes, target: Nodes, device: device, - pipeline: list = [], + pipeline: Optional[list] = None, manual_update: bool = False, traces: bool = False, **kwargs,