Type Checking

Author: Behemyth

cppython/builder.py

@@ -4,7 +4,7 @@
 from importlib.metadata import entry_points
 from inspect import getmodule
 from logging import Logger
-from typing import Any
+from typing import Any, cast
 
 from cppython.core.plugin_schema.generator import Generator
 from cppython.core.plugin_schema.provider import Provider
@@ -317,7 +317,7 @@ def create_scm(
         cppython_plugin_data = resolve_cppython_plugin(core_data.cppython_data, scm_type)
         scm_data = resolve_scm(core_data.project_data, cppython_plugin_data)
 
-        plugin = scm_type(scm_data)
+        plugin = cast(SCM, scm_type(scm_data))
 
         return plugin
 
@@ -354,7 +354,7 @@ def create_generator(
             cppython_data=cppython_plugin_data,
         )
 
-        return generator_type(generator_data, core_plugin_data, generator_configuration)
+        return cast(Generator, generator_type(generator_data, core_plugin_data, generator_configuration))
 
     def create_provider(
         self,
@@ -389,7 +389,7 @@ def create_provider(
             cppython_data=cppython_plugin_data,
         )
 
-        return provider_type(provider_data, core_plugin_data, provider_configuration)
+        return cast(Provider, provider_type(provider_data, core_plugin_data, provider_configuration))
 
 
 class Builder:

cppython/defaults.py

@@ -18,7 +18,7 @@ def __init__(self, group_data: SCMPluginGroupData) -> None:
         self.group_data = group_data
 
     @staticmethod
-    def features(_: DirectoryPath) -> SupportedSCMFeatures:
+    def features(directory: DirectoryPath) -> SupportedSCMFeatures:
         """Broadcasts the shared features of the SCM plugin to CPPython
 
         Returns:
@@ -36,7 +36,7 @@ def information() -> Information:
         return Information()
 
     @staticmethod
-    def version(_: DirectoryPath) -> str:
+    def version(directory: DirectoryPath) -> str:
         """Extracts the system's version metadata
 
         Returns:

cppython/plugins/cmake/plugin.py

@@ -28,7 +28,7 @@ def __init__(self, group_data: GeneratorPluginGroupData, core_data: CorePluginDa
         self._provider_directory = self._cppython_preset_directory / 'providers'
 
     @staticmethod
-    def features(_: Path) -> SupportedGeneratorFeatures:
+    def features(directory: Path) -> SupportedGeneratorFeatures:
         """Queries if CMake is supported
 
         Returns:

cppython/plugins/conan/builder.py

@@ -83,11 +83,11 @@ def _update_requires(self, updated_node: cst.ClassDef) -> cst.ClassDef:
 
         # Insert the new statement after the last attribute assignment
         if last_attribute is not None:
-            new_body = list(updated_node.body.body)
+            new_body = [item for item in updated_node.body.body]
             index = new_body.index(last_attribute)
             new_body.insert(index + 1, new_statement)
         else:
-            new_body = [new_statement] + list(updated_node.body.body)
+            new_body = [new_statement] + [item for item in updated_node.body.body]
         return updated_node.with_changes(body=updated_node.body.with_changes(body=new_body))
 
     def _replace_requires(

cppython/plugins/git/plugin.py

@@ -52,8 +52,7 @@ def information() -> Information:
         """
         return Information()
 
-    @staticmethod
-    def version(_: Path) -> str:
+    def version(self, directory: Path) -> str:
         """Extracts the system's version metadata
 
         Returns:

cppython/test/mock/generator.py

@@ -32,7 +32,7 @@ def __init__(
         self.configuration_data = MockGeneratorData(**configuration_data)
 
     @staticmethod
-    def features(_: DirectoryPath) -> SupportedGeneratorFeatures:
+    def features(directory: DirectoryPath) -> SupportedGeneratorFeatures:
         """Broadcasts the shared features of the generator plugin to CPPython
 
         Returns:
@@ -58,5 +58,5 @@ def sync_types() -> list[type[SyncData]]:
         """
         return [MockSyncData]
 
-    def sync(self, _: SyncData) -> None:
+    def sync(self, sync_data: SyncData) -> None:
         """Synchronizes generator files and state with the providers input"""

cppython/test/mock/provider.py

@@ -32,7 +32,7 @@ def __init__(
         self.configuration_data = MockProviderData(**configuration_data)
 
     @staticmethod
-    def features(_: DirectoryPath) -> SupportedProviderFeatures:
+    def features(directory: DirectoryPath) -> SupportedProviderFeatures:
         """Broadcasts the shared features of the Provider plugin to CPPython
 
         Returns:

cppython/test/mock/scm.py

@@ -18,9 +18,12 @@ def __init__(self, group_data: SCMPluginGroupData) -> None:
         self.group_data = group_data
 
     @staticmethod
-    def features(_: DirectoryPath) -> SupportedSCMFeatures:
+    def features(directory: DirectoryPath) -> SupportedSCMFeatures:
         """Broadcasts the shared features of the SCM plugin to CPPython
 
+        Args:
+            directory: The root directory where features are evaluated
+
         Returns:
             The supported features
         """
@@ -35,10 +38,12 @@ def information() -> Information:
         """
         return Information()
 
-    @staticmethod
-    def version(_: DirectoryPath) -> str:
+    def version(self, directory: DirectoryPath) -> str:
         """Extracts the system's version metadata
 
+        Args:
+            directory: The input directory
+
         Returns:
             A version
         """

cppython/test/pytest/base_classes.py

@@ -265,7 +265,8 @@ def fixture_plugin_group_data(
         Returns:
             The plugin configuration
         """
-        project_data.project_root = tmp_path_factory.mktemp('workspace-')
+        workspace_path = tmp_path_factory.mktemp('workspace-')
+        project_data = ProjectData(project_root=workspace_path, verbosity=project_data.verbosity)
         # Install path is already pinned to a temp directory to share downloaded resources
         cppython_plugin_data.build_path = project_data.project_root / 'build'
         cppython_plugin_data.tool_path = project_data.project_root / 'tool'
@@ -355,7 +356,8 @@ def fixture_plugin_group_data(
         Returns:
             The plugin configuration
         """
-        project_data.project_root = tmp_path_factory.mktemp('workspace-')
+        workspace_path = tmp_path_factory.mktemp('workspace-')
+        project_data = ProjectData(project_root=workspace_path, verbosity=project_data.verbosity)
         # Install path is already pinned to a temp directory to share downloaded resources
         cppython_plugin_data.build_path = project_data.project_root / 'build'
         cppython_plugin_data.tool_path = project_data.project_root / 'tool'
@@ -444,7 +446,8 @@ def fixture_plugin_group_data(
         Returns:
             The plugin configuration
         """
-        project_data.project_root = tmp_path_factory.mktemp('workspace-')
+        workspace_path = tmp_path_factory.mktemp('workspace-')
+        project_data = ProjectData(project_root=workspace_path, verbosity=project_data.verbosity)
         # Install path is already pinned to a temp directory to share downloaded resources
         cppython_plugin_data.build_path = project_data.project_root / 'build'
         cppython_plugin_data.tool_path = project_data.project_root / 'tool'

pyproject.toml

@@ -64,7 +64,6 @@ testpaths = ["tests"]
 
 [tool.ruff]
 line-length = 120
-preview = true
 
 [tool.ruff.lint]
 ignore = ["D206", "D300", "D415", "E111", "E114", "E117"]