fix(validation): wrong condition for required field (#99)

Author: jsulpis

libs/form-builder/src/lib/utils/__tests__/error.util.spec.js

@@ -0,0 +1,65 @@
+import { isStepInError } from '../error.util.ts';
+
+describe('isStepInError', () => {
+  let schema;
+  let errors;
+  let fieldsToCheckByStep;
+  let dirtyFields;
+  let defaultValues;
+
+  beforeEach(() => {
+    schema = {
+      fields: {
+        myField: {
+          id: 'myField',
+          type: 'text',
+          validation: {
+            required: {
+              value: false,
+              key: 'required',
+              message: 'please fill this field',
+            },
+          },
+        },
+      },
+      stepsById: ['step1'],
+      steps: {
+        step1: {
+          id: 'step1',
+          fieldsById: ['myField'],
+          submit: { label: 'submit' },
+        },
+      },
+    };
+    errors = {};
+    fieldsToCheckByStep = ['myField'];
+    dirtyFields = {};
+    defaultValues = {};
+  });
+
+  it('should return false if the field is empty and not required', () => {
+    const isInError = isStepInError({
+      schema,
+      errors,
+      fieldsToCheckByStep,
+      dirtyFields,
+      defaultValues,
+    });
+
+    expect(isInError).toBe(false);
+  });
+
+  it('should return true if the field is empty and required', () => {
+    schema.fields.myField.validation.required.value = true;
+
+    const isInError = isStepInError({
+      schema,
+      errors,
+      fieldsToCheckByStep,
+      dirtyFields,
+      defaultValues,
+    });
+
+    expect(isInError).toBe(true);
+  });
+});

libs/form-builder/src/lib/utils/error.util.ts

@@ -17,13 +17,13 @@ export const getFieldsToCheckByStep = ({
   return fieldsToCheck;
 };
 
-export const isFieldInError = ({ fieldToCheck, errors }: { fieldToCheck: string; errors: FieldErrors }) =>
+const isFieldInError = ({ fieldToCheck, errors }: { fieldToCheck: string; errors: FieldErrors }) =>
   !!(errors && errors[fieldToCheck]);
 
-export const isFieldRequired = ({ schema, fieldToCheck }: { schema: FormSchema; fieldToCheck: string }) =>
-  schema?.fields?.[fieldToCheck]?.validation?.[DEFAULT_RULES_NAMES.required];
+const isFieldRequired = ({ schema, fieldToCheck }: { schema: FormSchema; fieldToCheck: string }): boolean =>
+  !!schema?.fields?.[fieldToCheck]?.validation?.[DEFAULT_RULES_NAMES.required]?.value;
 
-export const isFieldNotDirtyAndEmpty = ({
+const isFieldNotDirtyAndEmpty = ({
   fieldToCheck,
   dirtyFields,
   defaultValues,