Add game wrapper for 2048 (homebrew)#418
Conversation
|
Awesome, I’ll get back to you asap, but it’ll take some days |
|
Can you point me to the ROM you used? The one here has a different MD5: |
|
Thanks for pointing that out! It seems I had an older version of the ROM. I've updated the wrapper to use the official ROM from wyattferguson's repository (MD5: |
There was a problem hiding this comment.
several unrelated formatting changes have been added, do see if these can be cleaned up.
| for p in sorted(list(set(plugins) - set(game_wrappers))): | ||
| p_name = to_snake_case(p) | ||
| spec = importlib.util.spec_from_file_location( | ||
| p_name, os.path.dirname(os.path.abspath(__file__)) + "/" + p_name + ".py" |
There was a problem hiding this comment.
here as well unrelated formatting changes have been introduced
There was a problem hiding this comment.
unrelated formatting changes have been added, please remove them
bhaskar253
left a comment
There was a problem hiding this comment.
several unrelated formatting changes have been added, please do avoid them
Adds a game wrapper for the 2048 homebrew Game Boy game by wyattferguson.MD5:
6748719720d57a7dce48d07b2f3c5edeSHA256:
a5dd7ad505baf13bdf66736518c2d6708459c3aaf1ed2d2282f05c2d1d958d9cThe wrapper provides:
Tests included in tests/test_2048.py