Fix checked status on page load

Author: carlbennett

src/templates/Packet/Edit.phtml

@@ -87,21 +87,21 @@ require('./header.inc.phtml');
             <table>
               <thead></thead><tbody>
 <?php function add_product_checkbox( $id, $name, $checked ) { ?>
-                  <td><input type="checkbox" id="<?php echo $id; ?>" name="used_by[]" value="<?php echo $id; ?>"<?php if ( $checked ) { ?> checked="checked"<?php } ?>/><label for="<?php echo $id; ?>"><?php echo $name; ?></label></td>
+                  <td><input type="checkbox" id="used_by_<?php echo $id; ?>" name="used_by[]" value="<?php echo $id; ?>"<?php if ( $checked ) { ?> checked="checked"<?php } ?>/><label for="used_by_<?php echo $id; ?>"><?php echo $name; ?></label></td>
 <?php }
 $product_ubound = count( $this->getContext()->products );
-for ( $product_i = 0; $product_i < $product_ubound; ++$product_i ) {
-  $p = $this->getContext()->products[ $product_i ];
-?>
+for ( $product_i = 0; $product_i < $product_ubound; ++$product_i ) { ?>
                 <tr>
 <?php
-  $checked = isset( $this->getContext()->used_by[ $p->getBnetProductId() ]);
+  $p = $this->getContext()->products[ $product_i ];
+  $checked = in_array( $p, $this->getContext()->used_by );
   add_product_checkbox( $p->getBnetProductId(), $p->getLabel(), $checked );
   if ( $product_i + 1 < $product_ubound ) {
     $p = $this->getContext()->products[ ++$product_i ];
-    $checked = isset( $this->getContext()->used_by[ $p->getBnetProductId() ]);
+    $checked = in_array( $p, $this->getContext()->used_by );
     add_product_checkbox( $p->getBnetProductId(), $p->getLabel(), $checked );
-  } ?>
+  }
+?>
                 </tr>
 <?php } ?>
               </tbody>