Skip to content

Update singularity check for KB camera model #242

@nickcharron

Description

@nickcharron

In this paper: https://arxiv.org/pdf/1807.08957.pdf

They describe that KB has a singularity at z = 0. In our InProjectionDomain function, we only check that z != 0

See check here:

bool KannalaBrandt::InProjectionDomain(const Eigen::Vector3d& point) {

Since it's a singularity, I think we should exclude points that are 'near' z = 0, not exact, as points approaching zero will probably give errors as well. Especially with machine rounding errors

@jakemclaughlin6 @adthoms (should be a quick fix if either of you have a minute)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions