Update HA validation and configuration #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request enhances HA cluster validation and configuration management for SAP HANA and SCS deployments on Azure. The changes focus on improving diagnostic capabilities, refining parameter validation messaging, updating cluster resource defaults, and extending support for filesystem resources.
Key Changes
- Cluster configuration snapshotting: Added automated capture of cluster configuration snapshots using OS-specific commands (
crm config showfor SUSE,pcs config showfor REDHAT) to include in test case reports for improved troubleshooting - Enhanced validation messaging: Improved error messages in parameter validation to include specific failed parameter names with their categories for better operator diagnostics
- Resource and operation defaults updates: Updated filesystem resource operation defaults for both SUSE and REDHAT, changed HANA migration-threshold to required, corrected REDHAT ChkSrv provider configuration, and added have-watchdog parameter
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vars/input-api.yaml | Added ha_cluster_config_dump command definition for both SUSE and REDHAT |
| src/roles/ha_scs/tasks/ha-config.yml | Implemented cluster configuration snapshot capture and included it in telemetry data |
| src/roles/ha_db_hana/tasks/ha-config.yml | Implemented cluster configuration snapshot capture with trimmed output and included it in telemetry data |
| src/roles/ha_scs/tasks/files/constants.yaml | Added filesystem resource operation defaults for both SUSE (60s stop timeout) and REDHAT (120s stop timeout) |
| src/roles/ha_db_hana/tasks/files/constants.yaml | Changed migration-threshold to required, added have-watchdog parameter, and updated ChkSrv provider configuration (execution_order: 2, action_on_host: kill) |
| src/roles/configuration_checks/tasks/files/hana.yml | Extended valid stonith-action list to include "stonith-action=reboot (default)" format |
| src/modules/get_pcmk_properties_scs.py | Added filesystem resource type to RESOURCE_CATEGORIES for validation support |
| src/module_utils/get_pcmk_properties.py | Enhanced validate_from_constants to provide detailed error messages with parameter names and categories, plus improved success/warning messaging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several improvements and updates to the HA cluster validation and configuration management, particularly for SAP HANA and SCS roles. The main focus is on enhancing cluster configuration snapshotting, improving parameter validation messaging, updating constants for resource and operation defaults, and extending support for new resource types.
Cluster configuration snapshotting and reporting:
ha_db_hanaandha_scsroles to capture a cluster configuration snapshot using the appropriate command for the OS, and include this snapshot in the test case report for improved diagnostics. (src/roles/ha_db_hana/tasks/ha-config.yml[1] [2];src/roles/ha_scs/tasks/ha-config.yml[3] [4];src/vars/input-api.yaml[5]Parameter validation and messaging improvements:
validate_from_constantsmethod to provide more detailed and user-friendly error messages, including specific failed parameter names and categories, and clearer status messages for warnings and successes. (src/module_utils/get_pcmk_properties.pysrc/module_utils/get_pcmk_properties.pyR564-L577)Resource and operation defaults updates:
migration-thresholdinRSC_DEFAULTSto be required. (src/roles/ha_db_hana/tasks/files/constants.yamlsrc/roles/ha_db_hana/tasks/files/constants.yamlL53-R56)ha_dr_provider_chksrvprovider, including provider name, execution order, and action on host. (src/roles/ha_db_hana/tasks/files/constants.yamlsrc/roles/ha_db_hana/tasks/files/constants.yamlL871-R885)have-watchdogand updated other CRM config defaults. (src/roles/ha_db_hana/tasks/files/constants.yamlsrc/roles/ha_db_hana/tasks/files/constants.yamlR37-R39)filesystemresource in both SCS and HANA constants. (src/roles/ha_scs/tasks/files/constants.yaml[1] [2]Resource and validation support extensions:
Filesystemprimitive in SCS validation and resource mapping. (src/modules/get_pcmk_properties_scs.pysrc/modules/get_pcmk_properties_scs.pyR169)Validation argument updates:
src/roles/configuration_checks/tasks/files/hana.ymlsrc/roles/configuration_checks/tasks/files/hana.ymlL162-R162)Problem Statement
Solution Details
Test Cases
Checklist
Dependencies
Screenshots/Logs
Additional Notes