HttpResponse mediaTypes and knownMediaType listed as required but are optional

[tjprescott]

perks/codemodel/.resources/all-in-one/json/code-model.json

Line 2999 in 793ed86

"mediaTypes",

I'm running into this generated snippet from the v4 code model:

            protocol: !<!Protocols> 
              http: !<!HttpResponse> 
                statusCodes:
                  - '200'

This is tagged as HttpResponse, and the definition of this schema in the code model says that both mediaTypes and knownMediaTypes are required. My understanding is that these properties should not be required in this scenario, and thus the code model is in error.

cc @sacheu @lmazuel

[daviwil]

Thanks for reporting this. You're right, these fields are specified as being required even when the response doesn't have a body. Converting these back to optional would be a breaking change for languages like C# that generate CodeModel types from these schemas. We might do this later so I'll leave this issue open until we decide to make the change.

/cc @pakrym

[pakrym]

We are fine reacting to the break that makes code model more correct.