Skip to content

new-extension-manifest does not generates a proper XML output #35

@Nimesh-Msys

Description

@Nimesh-Msys

While trying to execute the following command with CLI Version 1.2.4, we do get a proper expected XML output. But it doesn't works well with later versions.

Command

azure-extensions-cli_linux_amd64 new-extension-manifest \
--management-url URL \
--subscription-id ID \
--subscription-cert Cert \
--package Package \
--storage-base-url core.windows.net \
--storage-account Account \
--namespace Namespace \
--name Name \
--version Version \
--label Custom-Label \
--description Custom-Desc \
--eula-url EULA-URL \
--privacy-url Privacy-URL \
--homepage-url Homepage \
--company My-Company \
--supported-os windows

Output with CLI v1.2.7 & 1.2.6:

<ExtensionImage xmlns="">
  <ProviderNameSpace>Namespace</ProviderNameSpace>
  <Type>Name</Type>
  <Version>Version</Version>
  <Label>label</Label>
  <HostingResources></HostingResources>
  <MediaLink>ZIP</MediaLink>
  <Endpoints></Endpoints>
  <Description>description</Description>
  <LocalResources></LocalResources>
  <IsInternalExtension>true</IsInternalExtension>
  <Eula>eula-url</Eula>
  <PrivacyUri>privacy-url</PrivacyUri>
  <HomepageUri>homepage-url</HomepageUri>
  <IsJsonExtension>true</IsJsonExtension>
  <CompanyName>company</CompanyName>
  <SupportedOS>supported-os</SupportedOS>
</ExtensionImage>

Expected Output (Working till v1.2.4)

<?xml version="1.0" encoding="utf-8" ?>
<ExtensionImage xmlns="http://schemas.microsoft.com/windowsazure"  xmlns:i="http://www.w3.org/2001/XMLSchema-instance">
  <!-- WARNING: Ordering of fields matter in this file. -->
  <ProviderNameSpace>Namespace</ProviderNameSpace>
  <Type>Name</Type>
  <Version>Version</Version>
  <Label>Custom-Label</Label>
  <HostingResources>VmRole</HostingResources>
  <MediaLink>Zip</MediaLink>
  <Description>Custom-Desc</Description>
  <IsInternalExtension>true</IsInternalExtension>
  <Eula>EULA-URL</Eula>
  <PrivacyUri>Privacy-URL</PrivacyUri>
  <HomepageUri>Homepage</HomepageUri>
  <IsJsonExtension>true</IsJsonExtension>
  <CompanyName>My-Company</CompanyName>
  <SupportedOS>windows</SupportedOS>
  <!--%REGIONS%-->
</ExtensionImage>

What we see here is, only few user inputs are considered. We don't see any changes in help topics of new-extension-manifest. Is there anything we need to take care of or this PR might need to be revisited

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions