Bump minimum AKS version to 1.33.7 #3708 (#3712)

Author: BernieWhite

.github/copilot-instructions.md

@@ -16,3 +16,9 @@ Updating the change log:
 
 - After completing updates, update the change log in `docs/changelog.md` with a high-level one or two-line summary of the changes and the linked issue.
 - Change log entries are added as a new bullet point with the issue number in square brackets, under the Unreleased section.
+
+Common maintenance tasks:
+
+Periodically we need to run maintenance tasks to keep the repository up to date and ensure that all rules are compliant with the latest standards and practices. This includes:
+
+- Updating the minimum Kubernetes version for AKS clusters, see instructions in `.github/prompts/aks-minimum-version-update.prompt.md`.

.github/prompts/aks-minimum-version-update.prompt.md

@@ -0,0 +1,59 @@
+AKS Minimum Version - Update Instructions
+
+Purpose
+
+A concise guide to update the repository's AKS minimum Kubernetes version (configuration, docs, tests) while preserving baselines.
+
+Steps
+
+1. Branch
+- Create a feature branch: `git checkout -b <your-user>/bump-aks-minimum-1.33.7`
+
+2. Config
+- Edit `src/PSRule.Rules.Azure/rules/Config.Rule.yaml` and set:
+  - `AZURE_AKS_CLUSTER_MINIMUM_VERSION: '1.33.7'`
+
+3. Find & Update
+- Search the repo for the old version and the config key:
+  - `git grep -n "1.32.7"`
+  - `git grep -n "AZURE_AKS_CLUSTER_MINIMUM_VERSION"`
+- Update matching documentation, examples, and rule pages to `1.33.7` (notably `docs/examples/` and `docs/en/rules/`).
+
+4. Tests & Fixtures
+- Update unit tests and fixtures under `tests/PSRule.Rules.Azure.Tests/`:
+  - Replace `kubernetesVersion` / `orchestratorVersion` values in JSON/Bicep fixtures.
+  - Update assertion strings to reference the new constraint `>=1.33.7`.
+- Prefer targeted small edits for large JSON fixtures to avoid large-patch failures.
+
+5. Baselines (Important)
+- Do NOT change baseline files (e.g., `src/PSRule.Rules.Azure/rules/Baseline.Rule.yaml`).
+- Quick check: `git checkout -- src/PSRule.Rules.Azure/rules/Baseline.Rule.yaml` if you accidentally modify it.
+
+6. Verify
+- Run unit tests locally (may take time):
+
+PowerShell (recommended):
+
+Invoke-Build Test -AssertStyle Client
+
+Or run the VS Code task `test`.
+
+- Optionally run analyzer: `Invoke-Build Analyze`.
+
+7. Changelog & PR
+- Add a short changelog entry in `docs/changelog.md` under Unreleased mentioning the bump and that baselines were not updated.
+
+Example:
+
+```
+- Updated rules:
+  - Azure Kubernetes Service:
+    - Updated `Azure.AKS.Version` to use `1.33.7` as the minimum version by @BernieWhite.
+      [#nnnn](https://github.com/Azure/PSRule.Rules.Azure/issues/nnnn)
+```
+
+Notes & Tips
+
+- If a single large JSON patch fails, split edits into smaller targeted apply_patch operations.
+- Run `git status` frequently to ensure baselines remain untouched.
+- Include a link in the PR description to the related issue or changelog entry.

docs/changelog.md

@@ -30,6 +30,11 @@ See [upgrade notes][1] for helpful information when upgrading from previous vers
 
 ## Unreleased
 
+- Updated rules:
+  - Azure Kubernetes Service:
+    - Updated `Azure.AKS.Version` to use `1.33.7` as the minimum version by @BernieWhite.
+      [#3708](https://github.com/Azure/PSRule.Rules.Azure/issues/3708)
+
 ## v1.47.0
 
 What's changed since v1.46.0:

docs/concepts/about_PSRule_Azure_Configuration.md

@@ -50,7 +50,7 @@ Default:
 ```yaml
 # YAML: The default AZURE_AKS_CLUSTER_MINIMUM_VERSION configuration option
 configuration:
-  AZURE_AKS_CLUSTER_MINIMUM_VERSION: 1.32.7
+  AZURE_AKS_CLUSTER_MINIMUM_VERSION: 1.33.7
 ```
 
 Example:

docs/en/rules/Azure.AKS.NodeAutoUpgrade.md

@@ -57,7 +57,7 @@ resource cluster 'Microsoft.ContainerService/managedClusters@2024-10-01' = {
     }
   }
   properties: {
-    kubernetesVersion: '1.32.7'
+    kubernetesVersion: '1.33.7'
     enableRBAC: true
     dnsPrefix: dnsPrefix
     agentPoolProfiles: allPools
@@ -133,7 +133,7 @@ For example:
         }
     },
     "properties": {
-        "kubernetesVersion": "1.32.7",
+        "kubernetesVersion": "1.33.7",
         "enableRBAC": true,
         "dnsPrefix": "[parameters('dnsPrefix')]",
         "agentPoolProfiles": "[variables('allPools')]",

docs/en/rules/Azure.AKS.Version.md

@@ -66,7 +66,7 @@ resource cluster 'Microsoft.ContainerService/managedClusters@2024-10-01' = {
     }
   }
   properties: {
-    kubernetesVersion: '1.32.7'
+    kubernetesVersion: '1.33.7'
     enableRBAC: true
     dnsPrefix: dnsPrefix
     agentPoolProfiles: allPools
@@ -145,7 +145,7 @@ For example:
         }
     },
     "properties": {
-        "kubernetesVersion": "1.32.7",
+        "kubernetesVersion": "1.33.7",
         "enableRBAC": true,
         "dnsPrefix": "[parameters('dnsPrefix')]",
         "agentPoolProfiles": "[variables('allPools')]",
@@ -210,13 +210,13 @@ az aks update -n '<name>' -g '<resource_group>' --auto-upgrade-channel 'stable'
 ```
 
 ```bash
-az aks upgrade -n '<name>' -g '<resource_group>' --kubernetes-version '1.32.7'
+az aks upgrade -n '<name>' -g '<resource_group>' --kubernetes-version '1.33.7'
 ```
 
 ### Configure with Azure PowerShell
 
 ```powershell
-Set-AzAksCluster -Name '<name>' -ResourceGroupName '<resource_group>' -KubernetesVersion '1.32.7'
+Set-AzAksCluster -Name '<name>' -ResourceGroupName '<resource_group>' -KubernetesVersion '1.33.7'
 ```
 
 ## NOTES

docs/examples/resources/aks.bicep

@@ -46,7 +46,7 @@ param systemPoolMin int
 param systemPoolMax int = 3
 
 @description('The version of Kubernetes.')
-param kubernetesVersion string = '1.32.7'
+param kubernetesVersion string = '1.33.7'
 
 @description('Maximum number of pods that can run on nodes in the system pool.')
 @minValue(30)

docs/examples/resources/aks.json

@@ -73,7 +73,7 @@
     },
     "kubernetesVersion": {
       "type": "string",
-      "defaultValue": "1.32.7",
+      "defaultValue": "1.33.7",
       "metadata": {
         "description": "The version of Kubernetes."
       }

docs/setup/configuring-rules.md

@@ -207,7 +207,7 @@ Default:
 ```yaml title="ps-rule.yaml"
 # YAML: The default AZURE_AKS_CLUSTER_MINIMUM_VERSION configuration option
 configuration:
-  AZURE_AKS_CLUSTER_MINIMUM_VERSION: 1.32.7
+  AZURE_AKS_CLUSTER_MINIMUM_VERSION: 1.33.7
 ```
 
 Example:

src/PSRule.Rules.Azure/rules/Config.Rule.yaml

@@ -40,7 +40,7 @@ spec:
     AZURE_BICEP_CHECK_TOOL: false
 
     # Configures minimum AKS cluster version.
-    AZURE_AKS_CLUSTER_MINIMUM_VERSION: '1.32.7'
+    AZURE_AKS_CLUSTER_MINIMUM_VERSION: '1.33.7'
 
     # Configures the minimum allowed max pods setting per node pool.
     AZURE_AKS_POOL_MINIMUM_MAXPODS: 50