Creating a more friendly way of unlocking zones

[pkevan]

Currently when the zone lock times out the user is forced back to the tab/window where they were locked into a zone.

This is pretty bad UX and it would be nicer if it just silently took them out of the zone.

Reporting in Chrome (latest version) on Windows/Mac

[sboisvert]

@brettshumaker Can you have a look?

[brettshumaker]

@sboisvert While testing on the latest Chrome in Mac, if the user is still on the zone edit screen when the lock times out, an alert pops up that notifies them of the lock timeout. Once the user closes the notification or leaves the tab, the redirect occurs.

If the user is on another tab/window in Chrome when the lock times out, the redirect just happens without any notification but the user isn't forced back into the tab/window containing the zone edit screen. So it looks like this behavior may have been changed in Chrome since this issue was reported.

That being said, I can see how it could be jarring for a user who navigates back to edit a zone only to find themselves on the WordPress dashboard. I'd suggest keeping the JS alert with the redirect, but maybe just back to /wp-admin/admin.php?page=zoninator with an admin notice saying that their zone lock had expired.

Thoughts on that approach?

[sboisvert]

I'd suggest keeping the JS alert with the redirect, but maybe just back to /wp-admin/admin.php?page=zoninator with an admin notice saying that their zone lock had expired.

I like this idea. let's go with that.

[brettshumaker]

Currently when the zone lock times out the user is forced back to the tab/window where they were locked into a zone.

@pkevan Are you still seeing this behavior in the latest version of Chrome?

[sboisvert]

Even if the tab doesn't steal the focus anymore I think we can go forward with this change.

[pkevan]

@pkevan Are you still seeing this behavior in the latest version of Chrome?

Sorry, meant to reply earlier (but forgot), I had the tab still open but it didn't force me to that tab (or I would have replied sooner :) )

I agree that having some message to indicate it's been moved would be useful.

[brettshumaker]

@pkevan Thanks for the follow up! 👍

[brettshumaker]

@sboisvert See this commit for the admin notice addition: 6cc0194

[pkevan]

@brettshumaker can you make this a PR?

[brettshumaker]

@pkevan Done. 👍 #74