chore: align lint formatting and shrink long test lines

Author: Automaticare

app/services/__init__.py

@@ -45,3 +45,44 @@
     update_position,
 )
 from .scheduler import ensure_refresh_state, init_scheduler
+
+__all__ = [
+    "init_registry",
+    "Orchestrator",
+    "SnapshotRecord",
+    "create_orchestrator",
+    "init_orchestrator",
+    "PortfolioCreateData",
+    "PortfolioDTO",
+    "PortfolioListResult",
+    "PortfolioUpdateData",
+    "create_portfolio",
+    "delete_portfolio",
+    "get_portfolio",
+    "list_portfolios",
+    "update_portfolio",
+    "CurrencyExposure",
+    "PortfolioDailyPnLResult",
+    "PortfolioExposureResult",
+    "PortfolioValueResult",
+    "PortfolioValueSeriesPoint",
+    "PortfolioValueSeriesResult",
+    "PortfolioWhatIfResult",
+    "calculate_currency_exposure",
+    "calculate_daily_pnl",
+    "calculate_portfolio_value",
+    "calculate_portfolio_value_series",
+    "simulate_currency_shock",
+    "PositionCreateData",
+    "PositionDTO",
+    "PositionListParams",
+    "PositionListResult",
+    "PositionUpdateData",
+    "create_position",
+    "delete_position",
+    "get_position",
+    "list_positions",
+    "update_position",
+    "ensure_refresh_state",
+    "init_scheduler",
+]

app/services/portfolio_metrics.py

@@ -170,7 +170,7 @@ def _rates_for_timestamps(
         rates = grouped.setdefault(normalized_ts, {})
         rates[normalize_currency(target_code)] = rate
 
-    for normalized_ts, rates in grouped.items():
+    for _timestamp, rates in grouped.items():
         if rates:
             rates[base_code] = Decimal("1")
 

app/services/position_manager.py

@@ -239,7 +239,6 @@ def _normalize_side(
 
 
 def _raise_integrity_error(exc: IntegrityError) -> None:
-    message = str(getattr(exc, "orig", exc))
     raise APIError("Unable to process position request.", status_code=400) from exc
 
 

tests/e2e/providers.py

@@ -7,6 +7,7 @@
 from dataclasses import dataclass
 from datetime import UTC, datetime
 from decimal import Decimal
+
 from app.providers import (
     BaseRateProvider,
     ProviderError,

tests/test_backfill.py

@@ -51,8 +51,12 @@ def test_run_backfill_persists_history(client, monkeypatch, history_series):
     original_codes = registry.codes
     registry.codes = {"USD", "EUR"}
 
-    persisted = []
-    monkeypatch.setattr("app.services.backfill.persist_snapshot", lambda snapshot: persisted.append(snapshot))
+    persisted: list = []
+
+    def _capture_snapshot(snapshot):
+        persisted.append(snapshot)
+
+    monkeypatch.setattr("app.services.backfill.persist_snapshot", _capture_snapshot)
 
     try:
         with app.app_context():

tests/test_rate_store.py

@@ -28,10 +28,14 @@ def test_persist_snapshot_normalizes_timestamp_to_utc(app):
 
         persist_snapshot(snapshot)
 
+        query = text(
+            "SELECT timestamp FROM fx_rates "
+            "WHERE base_currency_code = :base "
+            "AND target_currency_code = :target "
+            "AND source = :source"
+        )
         raw_value = session.execute(
-            text(
-                "SELECT timestamp FROM fx_rates WHERE base_currency_code=:base AND target_currency_code=:target AND source=:source"
-            ),
+            query,
             {"base": "USD", "target": "EUR", "source": "mock"},
         ).scalar_one()
 

tests/test_rates_refresh.py

@@ -32,11 +32,22 @@ def snapshot():
     )
 
 
+def _increment_persist_counter(counter):
+    def _increment(_snapshot):
+        counter["persist"] += 1
+
+    return _increment
+
+
+def _raise_should_not_persist(_snapshot):
+    raise RuntimeError("should not persist")
+
+
 def test_manual_refresh_returns_accepted(client, snapshot, monkeypatch):
     calls = {"persist": 0}
     monkeypatch.setattr(
         "app.rates.routes.persist_snapshot",
-        lambda snapshot: calls.__setitem__("persist", calls["persist"] + 1),
+        _increment_persist_counter(calls),
     )
 
     app = client.application
@@ -61,7 +72,7 @@ def test_manual_refresh_returns_accepted(client, snapshot, monkeypatch):
 def test_manual_refresh_throttles_requests(client, snapshot, monkeypatch):
     monkeypatch.setattr(
         "app.rates.routes.persist_snapshot",
-        lambda snapshot: (_ for _ in ()).throw(RuntimeError("should not persist")),
+        _raise_should_not_persist,
     )
 
     app = client.application
@@ -77,7 +88,7 @@ def test_manual_refresh_throttles_requests(client, snapshot, monkeypatch):
 
 
 def test_manual_refresh_reports_provider_error(client, monkeypatch):
-    monkeypatch.setattr("app.rates.routes.persist_snapshot", lambda snapshot: None)
+    monkeypatch.setattr("app.rates.routes.persist_snapshot", lambda _snapshot: None)
 
     app = client.application
     app.extensions["fx_orchestrator"] = DummyOrchestrator(error=ProviderError("primary down"))
@@ -94,7 +105,7 @@ def test_manual_refresh_respects_zero_throttle(client, snapshot, monkeypatch):
     calls = {"persist": 0}
     monkeypatch.setattr(
         "app.rates.routes.persist_snapshot",
-        lambda snapshot: calls.__setitem__("persist", calls["persist"] + 1),
+        _increment_persist_counter(calls),
     )
 
     app = client.application