fix(forge-vesting-factory): add TTL extension calls for all persisten…#525
Merged
Austinaminu2 merged 2 commits intoApr 28, 2026
Merged
Conversation
…t storage entries Persistent storage entries on Stellar expire after ~30 days without a TTL bump. Without extend_ttl calls, a beneficiary who does not interact with their schedule for 30 days would find their vesting data expired, causing claim() to return ScheduleNotFound and locking their tokens forever. Changes: - extend_ttl for DataKey::Schedule(id) in create_schedule(), claim(), cancel() - extend_ttl for DataKey::Claimed(id) in claim() and cancel() - extend_ttl for DataKey::ScheduleCount in create_schedule() - extend_ttl for DataKey::VestedAtCancel(id) in cancel() - All bumps use (17280, 34560) ledgers to match forge-governor, forge-multisig, forge-stream - Document TTL strategy in factory README Closes Austinaminu2#499
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t storage entries
Persistent storage entries on Stellar expire after ~30 days without a TTL bump. Without extend_ttl calls, a beneficiary who does not interact with their schedule for 30 days would find their vesting data expired, causing claim() to return ScheduleNotFound and locking their tokens forever.
Changes:
Closes #499
Summary
[Provide a clear and concise summary of the changes made in this PR]
Related issue
[Link to the issue, e.g., #123]
Related Issue
[Link to the issue this PR addresses, e.g. Closes #123]
Type of Change
Testing
Tests Performed
[Describe the tests you ran to verify your changes. Include:
Test Results
[All tests should pass. Include any test output or screenshots if relevant]
Checklist
cargo fmtto format the codecargo clippyto lint the codeAdditional Notes
[Any additional context, screenshots, or information that reviewers should be aware of]